Comments (5)
Hi there,
I'm also encountering this issue, both in my source code when e.g. checking the RuleType
of a given node:
Cannot access ambient const enums when 'isolatedModules' is enabled. ts(2748)
But more importantly when running tests with Jest, tests of code involving RuleType
fail with the following error:
TypeError: Cannot read properties of undefined (reading 'htmlBlock') Jest
From what I could gather, the official recommendation from TypeScript is to completely avoid the use of const enums, including publishing ambient const enums: https://blog.beraliv.dev/2022-09-10-with-or-without-enums#ambient-const-enum-pitfalls.
Perhaps it would be worth considering converting RuleType to a simple object instead of an enum?
Thanks for this library, it's really great that it's so small!
from markdown-to-jsx.
Hmm, what's the fix? I don't use isolatedModules
in the tsconfig.json
for this library
from markdown-to-jsx.
Perhaps it would be worth considering converting RuleType to a simple object instead of an enum?
Yeah, I think that's the way to go. Would you be interested in submitting a PR? Have a bunch of life stuff going on atm so not sure when I will be able to work on this.
from markdown-to-jsx.
Hello @quantizor, sure I can take a look, also quite busy but I think it could be worth it! I'll try to tackle it in the coming weeks and keep you updated on my progress.
from markdown-to-jsx.
Hi there @quantizor, sorry for the long wait, but I finally had some time to look into refactoring the const enum
for the RuleType
into an object. I created a PR here : #594
It would be great if you could have a look, the changes are fairly minor and should not impact the usage of the library at all.
Let me know what you think, I hope this approach makes sense and can make the library easier to integrate with different bundling setups.
from markdown-to-jsx.
Related Issues (20)
- follow up on #520 HOT 1
- 在引用块第一位使用 kbd标签后面链接无法正常解析
- Unexpected nested list behavior
- Ordered list is not generated if there's no newline at the end
- Double line breaks (\n\n) are not converted properly HOT 2
- Error using divider with `---` HOT 1
- Empty `<style></style>` or `<style />` causes library to crash
- React 19 incompatibility
- unordered lists don't work
- How to prevent html tag shown when doing streaming
- Nested UL crash rendering
- Feature request: Handle user selection change event in rendered Markdown. Emit an event that returns the corresponding selection in plain Markdown
- include ref property to any div crashes
- type "[key: string]: any" makes extension difficult
- Editing overrides in nested markdown
- Pipe breaks the heading formatting
- Option to provide a custom component as wrapper / pass className to wrapper? HOT 1
- Script tag causes exception
- Trivial RegExp DoS (leading spaces) HOT 2
- parse link incorrectly when both have italic text and link which include '_-'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from markdown-to-jsx.