Coder Social home page Coder Social logo

The presence of two or more same-name html elements inside another html element will produce borked output about markdown-to-jsx HOT 3 CLOSED

quantizor avatar quantizor commented on May 27, 2024
The presence of two or more same-name html elements inside another html element will produce borked output

from markdown-to-jsx.

Comments (3)

bathos avatar bathos commented on May 27, 2024

Found it. The HTML_BLOCK_ELEMENT_R pattern is greedy about its content:

const HTML_BLOCK_ELEMENT_R = /^ *<([^ >]*) ?([^>]*)>((?:.|(?!\n *<\1)\n)*)<\/\1>\n*/;

This can be (sorta) fixed by changing it to:

const HTML_BLOCK_ELEMENT_R = /^ *<([^ >]*) ?([^>]*)>((?:.|(?!\n *<\1)\n)*?)<\/\1>\n*/;

But looking at this pattern, I’m pretty sure there are a bunch of other ways it can go south even with that fix though. This may just not be a good way to capture HTML.

In any case, this issue isn’t specific to <dl> and co. It affects any HTML sequence where an element has more than one child at any depth that has the same name.

from markdown-to-jsx.

quantizor avatar quantizor commented on May 27, 2024

But looking at this pattern, I’m pretty sure there are a bunch of other ways it can go south even with that fix though. This may just not be a good way to capture HTML.

That's definitely true, but I'm sort of okay with that for the time being since this strategy strikes a good balance between functionality and bundle size. Markdown in HTML tends to be rare, so we'll fix the issues as they come up and I'll work on putting together more comprehensive test cases.

from markdown-to-jsx.

quantizor avatar quantizor commented on May 27, 2024

Released in 6.1.4

from markdown-to-jsx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.