Use ember-cli-compass-compiler to compile Sass in addons? about ember-cli-compass-compiler

[quaertym]

Please link an addon that uses broccoli-sass, I will take a look at it.

[lolmaus]

https://github.com/Blooie/ember-cli-notifications

[lolmaus]

Also keep this in mind: ember-cli/ember-cli#2363

[shaunc]

having problems with https://github.com/yapplabs/ember-modal-dialog

EDIT ... right now I'm using compassOptions to make sure that addon sass is accessible:

compassOptions: {
  outputStyle: 'expanded',
  importPath: [
    'bower_components/bootstrap-sass/assets/stylesheets',
    'bower_components',
    'node_modules/ember-modal-dialog/app/styles/'
  ]

This works -- but is this how it should work? Or should /app/styles/... be automatically added to path?

[quaertym]

@stefanpenner Can you help us here? Can addon styles be compiled with ember-cli-compass-compiler instead of broccoli-sass? Or addon decides its preprocessor?

[AndrewJo]

With recent Ember CLI versions (I'm currently on 1.13.x), I believe ember-cli-sass is the package to look at for compiling SASS instead of broccoli-sass.

However, I looked into this and upon analyzing the source code, realized that there's a bug in https://github.com/quaertym/ember-cli-compass-compiler/blob/master/index.js#L40:

var inputTrees = [inputPath];

Should really be replaced with:

var inputTrees = [tree];

Otherwise, you will get an error like this when running ember build to build an addon that depends on ember-cli-compass-compiler:

Build failed.
ENOENT: no such file or directory, lstat ''
Error: ENOENT: no such file or directory, lstat ''

Other Ember CLI preprocessor addons already do this:

• ember-cli-sass:index.js (line 16)
• ember-cli-less:index.js (line 28)

I'll submit a PR that fixes this. There's also an issue of passing compass options for addons which I'll report separately.

[AndrewJo]

@quaertym: I've managed to fix it without modifying a single line of code broccoli-compass-compiler. I must say, it was a fun problem to solve! 😁

[quaertym]

@AndrewJo 👏 👏 congratulations, I will review and merge ASAP.