Coder Social home page Coder Social logo

Comments (12)

qmonnet avatar qmonnet commented on May 22, 2024

Thanks for the report. I don't have a machine running macOS at hand so I've never tried compiling rbpf on this OS, would you know what function we could use instead?

from rbpf.

waywardmonkeys avatar waywardmonkeys commented on May 22, 2024

I was just looking at preparing a patch that uses std::time::{Instant,Duration} (https://doc.rust-lang.org/std/time/struct.Instant.html) instead ...

from rbpf.

waywardmonkeys avatar waywardmonkeys commented on May 22, 2024

Well, that won't work... but I'll submit a pull request that fixes on macOS within a day.

from rbpf.

qmonnet avatar qmonnet commented on May 22, 2024

No hurry here, thanks a lot!

from rbpf.

badboy avatar badboy commented on May 22, 2024

While at it we could add MacOS as a target on Travis to make sure it continues to work

from rbpf.

qmonnet avatar qmonnet commented on May 22, 2024

Yeah, that's a good idea. We can do that once this bug is fixed and we have something that compiles.

While we're at it, I've not tried on Windows, either. I don't know if it compiles (the clock_gettime probably fails as well, but what else?). Has anyone here tried to work with Rust on Windows?

from rbpf.

badboy avatar badboy commented on May 22, 2024

AppVeyor is free and easy to setup as CI as well to run the build. The jitting might be incompatible, but the rest should probably work.

from rbpf.

waywardmonkeys avatar waywardmonkeys commented on May 22, 2024

My change to use the time crate will let that code at least work on Windows. I can't speak to any of the rest of it.

from rbpf.

badboy avatar badboy commented on May 22, 2024

I can take care of an AppVeyor config today

from rbpf.

qmonnet avatar qmonnet commented on May 22, 2024

@waywardmonkeys: Your patch works fine on Linux, thanks a lot! There is just a sentence that we should remove from the comment of the function, see review in the PR.

@badboy: Thanks a lot, I'd be glad to let you have a look. Tell me if you need some specific rights on the repo to make this work.

I really appreciate your help and motivation! :-)

from rbpf.

waywardmonkeys avatar waywardmonkeys commented on May 22, 2024

@qmonnet I'll fix up the PR shortly. Dinner time here!

from rbpf.

qmonnet avatar qmonnet commented on May 22, 2024

No problem. Bon appétit!

from rbpf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.