Comments (12)
Thanks for the report. I don't have a machine running macOS at hand so I've never tried compiling rbpf on this OS, would you know what function we could use instead?
from rbpf.
I was just looking at preparing a patch that uses std::time::{Instant,Duration}
(https://doc.rust-lang.org/std/time/struct.Instant.html) instead ...
from rbpf.
Well, that won't work... but I'll submit a pull request that fixes on macOS within a day.
from rbpf.
No hurry here, thanks a lot!
from rbpf.
While at it we could add MacOS as a target on Travis to make sure it continues to work
from rbpf.
Yeah, that's a good idea. We can do that once this bug is fixed and we have something that compiles.
While we're at it, I've not tried on Windows, either. I don't know if it compiles (the clock_gettime
probably fails as well, but what else?). Has anyone here tried to work with Rust on Windows?
from rbpf.
AppVeyor is free and easy to setup as CI as well to run the build. The jitting might be incompatible, but the rest should probably work.
from rbpf.
My change to use the time
crate will let that code at least work on Windows. I can't speak to any of the rest of it.
from rbpf.
I can take care of an AppVeyor config today
from rbpf.
@waywardmonkeys: Your patch works fine on Linux, thanks a lot! There is just a sentence that we should remove from the comment of the function, see review in the PR.
@badboy: Thanks a lot, I'd be glad to let you have a look. Tell me if you need some specific rights on the repo to make this work.
I really appreciate your help and motivation! :-)
from rbpf.
@qmonnet I'll fix up the PR shortly. Dinner time here!
from rbpf.
No problem. Bon appétit!
from rbpf.
Related Issues (20)
- prog_exec has no way to report a vm error HOT 10
- Provide Helper function type HOT 1
- Define a type for the eBPF helper functions HOT 1
- Valid mod operations cause a div/0 exception HOT 5
- Support for 32-bit jump instructions HOT 1
- Is only support x86_64? HOT 10
- Incorrect sign extension when moving signed 32 bit immediate into 64 bit register HOT 1
- logo update for dark theme HOT 2
- panicked at 'attempt to add with overflow' HOT 3
- panicked at 'attempt to shift left with overflow HOT 1
- panicked at 'attempt to calculate the remainder with a divisor of zero'
- panicked at 'attempt to divide by zero'
- Fix behaviour for division/modulus by 0
- rbpf panic when running bpf_conformance with JIT HOT 1
- rbpf incorrectly rejects last instruction is not an exit
- Support atomic instructions
- Tests panick with `misaligned pointer dereference: address must be a multiple of ... but is ...` HOT 5
- Appveyor tests are flaky (Cargo fails to download dependencies) HOT 1
- Support uprobe and kprobe? HOT 2
- Segmentation fault when executing jitted program HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rbpf.