Coder Social home page Coder Social logo

`npm run test` fails on windows about qmlweb HOT 5 OPEN

bessorion avatar bessorion commented on June 11, 2024
`npm run test` fails on windows

from qmlweb.

Comments (5)

bessorion avatar bessorion commented on June 11, 2024

I suppose it's because of encoding. Warning valid for 80-character lines (because of line-ending?)
Also some windows editors visualize symbols « » and — in wrong way, but it's not so critical.

from qmlweb.

bessorion avatar bessorion commented on June 11, 2024

./node_modules/remark-lint/lib/rules/maximum-line-length.js

function maximumLineLength(ast, file, preferred) {
var style = preferred && preferred !== true ? preferred : 80;
var content = file.toString();
var matrix = content.split('\n');
var index = -1;
var length = matrix.length;
var lineLength;

And I see via Hex-editor 0D0A line endings in my local files.

from qmlweb.

ChALkeR avatar ChALkeR commented on June 11, 2024

@bessorion Yeah, that makes sense, thanks!
Looks like a remark-lint bug.

Will try to update to the latest version (that requires changes on QmlWeb side, see #412), if that won't fix things — will take a look at remark side.

from qmlweb.

bessorion avatar bessorion commented on June 11, 2024

I think migration to 6.0.0 should solve problem:
https://github.com/remarkjs/remark-lint/blob/master/packages/remark-lint-maximum-line-length/index.js

function maximumLineLength(ast, file, preferred) {
  var style = preferred && preferred !== true ? preferred : 80;
  var content = file.toString();
  var matrix = content.split(/\r?\n/);

from qmlweb.

Plaristote avatar Plaristote commented on June 11, 2024

We migrated remark-lint to 9.1.0 (time flies, doesn't it) ! I assume the issue has been resolved ?

from qmlweb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.