HSL percentage properties should be modify by percent as is about color

[Qix-]

I'm not entirely sure what you're suggesting. Could you show me some examples of what sass does vs what color does?

[ivansky]

Lightness is a percent value.

Sass:

For example,

In HSL the black color has 0% lightness and the white has 100%.

Less

Lighten and darken in less: http://lesscss.org/functions/#color-operations-lighten

Color library:

If we look at the behavior of Color library, we will see not expected result:
Example

Epilogue

So I suggest to do that like in a lot of open source projects.

Change:

lighten: function (ratio) {
    this.values.hsl[2] += this.values.hsl[2] * ratio;
    this.setValues('hsl', this.values.hsl);
    return this;
}
darken: function (ratio) {
    this.values.hsl[2] -= this.values.hsl[2] * ratio;
    this.setValues('hsl', this.values.hsl);
    return this;
}

To:

lighten: function (ratio) {
    this.values.hsl[2] += ratio * 100;
    this.setValues('hsl', this.values.hsl);
    return this;
}
darken: function (ratio) {
    this.values.hsl[2] -= ratio * 100;
    this.setValues('hsl', this.values.hsl);
    return this;
}

[ivansky]

What do you think about it?

[Qix-]

I'll have to look at it. Not entirely sure why youre multiplying by 100%, or what this is solving. I'll investigate a bit further :)

[ivansky]

I made the request ;) #92

[ivansky]

Let's continue talking about it in pull request #92