'.mix()' method fails to work with cloned color about color

[MoOx]

I'm guessing clone() method is not working properly.

[ZuBB]

Just a question of interest: Are you aware if usage of .clone() give some performance over Color()?

[MoOx]

clone() use Color() :)

[MoOx]

Btw, that's probably why it's buggy.

[ZuBB]

OK, thanks for reply..

[iamstarkov]

@ZuBB can you create pull-request with failing tests?

[ZuBB]

Hi Vladimir!

I am very busy right now with my own stuff. If this can wait for a couple
of weeks then I will try to do it. Otherwise please assign this to other
person
On Jun 17, 2015 06:06, "Vladimir Starkov" [email protected] wrote:

@ZuBB https://github.com/ZuBB can you create pull-request with failing
tests?

—
Reply to this email directly or view it on GitHub
#46 (comment).

[iamstarkov]

okie

[iamstarkov]

@ZuBB please, check 0.9 release. I fixed incorrect implementation

[MoOx]

Closing for now, feel free to reopen if you still have issues.

[ZuBB]

I made a hacked build (due to other reasons) with new 'mix' method only and things become event worse

I did small investigation and found that mix method started to fail case that used to pass. see #61

[ZuBB]

@MoOx do you reopen this?

[Qix-]

Hi @ZuBB, could you provide a few tests showing the break? If you provide them here I can clean them up and put them in myself.

[wmira]

I think the immutability PR fixes this. I used the test below. @ZuBB please advise if my test case is wrong. The test below fails on previous version.

describe('mixing bug works with immutable', function () {
    it('mix produces proper color with clone or constructor or instance', function () {
        var baseColor = Color('#73FF73');
        var gtColor = Color('#FF7400');
        var ltColor = Color('#004DFF');

        [1, 2, 1.3, 1.4, 2.5, 4, 0.7, 8, 1.3].forEach(function (value) {
            var otherColor = value > 1 ? gtColor : ltColor;
            var weight = (value > 1 ? (value - 1) : (1 - value)) * 3;
            var resultColor1 = baseColor.clone().mix(otherColor, weight);
            var resultColor2 = Color('#73FF73').mix(otherColor, weight);
            var resultColor3 = baseColor.mix(otherColor, weight);
            deepEqual(resultColor1, resultColor2);
            deepEqual(resultColor2, resultColor1);
            deepEqual(resultColor1, resultColor3);
            deepEqual(resultColor3, resultColor1);
            deepEqual(resultColor2, resultColor3);
            deepEqual(resultColor3, resultColor2);
        });
    });
});

[ZuBB]

Hi @wmira!

I do not have a chance to test/run your code but for me it looks it have to cover buggy case.

[stevemao]

I'm having trouble with the mix() function here
https://github.com/stevemao/color-transitions/blob/master/index.js#L38-L39

const color = color1.clone();
color.mix(color2, percent);

assume color1 is 'blue' and color2 is 'red', percent is 0.3
I was expecting it's 70% blue and 30% red, but it doesn't look like so.

[Qix-]

Hey everyone. The cloning problem has been addressed in the rewrite (there is no .clone() method anymore - you'll just pass another color). Hopefully this fixes all of these problems. 💃

Any new issues should be opened as a new bug since it pertains to the rewrite.

[Qix-]

Closing this since I believe this is fixed. Please let me know if that's not the case!