Coder Social home page Coder Social logo

Comments (3)

jakelishman avatar jakelishman commented on June 2, 2024

Looking more right now, OptimizeSwapBeforeMeasure has several components that are pretty broken, or at least rather unoptimal. DAGCircuit.descendants produces an unordered set (why?), so iterating through that has no particular order, and I don't think it's guaranteed to produce correct results. Similarly, DAGCircuit.op_nodes is not topological, so there's no guarantee that the swaps are visited in the best order, even if reversed.

from qiskit.

mtreinish avatar mtreinish commented on June 2, 2024

Yeah, my thinking is this pass would be supersceded by ElidePermutations so performance improvements for it shouldn't be critical. Im thinking we'll want to deprecate it in 1.2 for removal in 2.0. But we definitely should try to fix correctness issues for the 1.x branch where we can.

from qiskit.

jakelishman avatar jakelishman commented on June 2, 2024

I guess the reason it might not be totally supplanted is that this pass might still have worth in a pipeline for a backend that has a native swap - in that case, it might still have value in a post-translation and post-routing optimisation layout, where ElidePermutations would invalidate the coupling constraints. This never invalidates coupling constraints because it's a limited form of swap/permutation elision where it only affects gates that are followed by 1q operations (or other swaps).

That said, we could probably teach ElidePermutations to have a coupling-aware version of itself as well, if we chose.

from qiskit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.