libzip in qgis master about homebrew-qgisdev

[timlinux]

Thanks @Gustry this works for me...

[ismailsunni]

Just in case anyone know the solution of my issue.
I already did the comments from @Gustry , but unfortunatelly, I always got this error message:

/Users/ismailsunni/dev/cpp/QGIS/src/core/qgsziputils.cpp:21: error: 'zip.h' file not found
#include "zip.h"
         ^

I also have tried to do clean build, but I still got the issue.

[g-sherman]

I'm having the same issue. Solution above doesn't work for me, neither does building libzip from source.

[Gustry]

I'm not sure if @ismailsunni could fix it, but I saw he added
${LIBZIP_INCLUDE_DIR} in his src/core/CMakeLists.txt in the INCLUDE_DIRECTORIES on his pending PR.
Can you try @g-sherman?

[g-sherman]

LIBZIP_INCLUDE_DIR is already set in my cmake. zip.h exists in /usr/local/include. Adding
make -I/usr/local/Cellar/libzip/1.2.0/include -I/usr/local/Cellar/libzip/1.2.0/lib/libzip/include
(obtained from pkg-config --cflags libzip) doesn't help.

[g-sherman]

Seems cmake isn't configuring the includes for libzip properly on OSX. If you use make VERBOSE=1 you'll see they aren't there. I captured the compile command for qgsziputils.cpp using make VERBOSE=1, added the includes obtained from pkg-config --cflags libzip, then compiled it separately without error.

[dakcarto]

Between qgis/QGIS@83aa1ad and recent updates to qgis3-dev (specifically 133d229), it should be functioning now.

[dakcarto]

Closing, please reopen if needed.