Invalid hook path and script when using git_path about elixir_git_hooks

[felipeloha]

you can workaround this with the following configuration
mix_path: "cd my_app && mix",

[qgadrian]

Closing this issue as it should be fixed in the latest release

[felipeloha]

+1

[qgadrian]

It's been a while, but this got fixed 49ca50e

I just tested a submodule project and the hooks are installed under .git/modules/my-other-project/hooks/

@colinsmetz can you check the pre-release v0.6.6-pre?

[colinsmetz]

I don't use submodules, so I'm not sure my issue was clear.

I just tried again using the tag v0.6.6-pre and I mostly have the same behaviours :

• The git hook is installed in my_app/deps/.git/pre-commit when I do a mix compile
• If I run mix git_hooks.install it uses my git_path. There was a difference though. With the git_path set to ../.git (as I did before), the pre-commit hook is created at .git/pre-commit instead of .git/hooks/pre-commit. I had to set it to ../git/hooks now.
• The pre-commit script does not cd inside the folder with the Elixir project, so it fails

Note that I may have misunderstood the point of git_path. Is it limited to git submodules only?

[colinsmetz]

you can workaround this with the following configuration
mix_path: "cd my_app && mix",

Thanks, that solves my last point indeed.

[qgadrian]

I don't use submodules, so I'm not sure my issue was clear.

I just tried again using the tag v0.6.6-pre and I mostly have the same behaviours :

* The git hook is installed in `my_app/deps/.git/pre-commit` when I do a `mix compile`

* If I run `mix git_hooks.install` it uses my `git_path`. There was a difference though. With the `git_path` set to `../.git` (as I did before), the pre-commit hook is created at `.git/pre-commit` instead of `.git/hooks/pre-commit`. I had to set it to `../git/hooks` now.

* The pre-commit script does not `cd` inside the folder with the Elixir project, so it fails

Note that I may have misunderstood the point of git_path. Is it limited to git submodules only?

git_path is not limited to submodules, actually, it should not be used on git submodules and this project supports them out of the box without any additional configuration.

I just tested an elixir project in a subfolder, and the following config installed the hooks on the correct parent path when running mix deps.compile git_hooks.

  config :git_hooks,
    git_path: "../.git",
    auto_install: true,
    verbose: true,
    hooks: [
      pre_commit: [
        tasks: [
          {:mix_task, :format, ["--dry-run", "--check-formatted"]}
        ]
      ]
    ]

I don't link the git_path config, the name is misleading and the path should be resolved automatically. So thanks to the changes on this PR you won't need to set any custom path, it will just work (hopefully).

I just tested myself with both git submodules and a simple elixir subfolder (no submodule) and both the install and the hooks worked fine. There is a pre-release available on hex.