pkg-config detected `xtb` dependency fails to link about xtb_wrapper

[awvwgk]

I applied this patch as fix

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8618a27..f293f9a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -14,7 +14,10 @@ set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_CURRENT_SOURCE_DIR}/dev/cmake
 
 # Find xtb
 find_package(xtb QUIET)
-if(NOT TARGET lib-xtb-static)
+if(TARGET lib-xtb-static)
+  add_library(xtb::xtb INTERFACE IMPORTED)
+  target_link_libraries(xtb::xtb INTERFACE lib-xtb-static)
+else()
   find_package(PkgConfig REQUIRED)
   pkg_check_modules(XTB QUIET xtb)
   if(XTB_FOUND)
diff --git a/src/Xtb/CMakeLists.txt b/src/Xtb/CMakeLists.txt
index 76604eb..d9b4fd2 100644
--- a/src/Xtb/CMakeLists.txt
+++ b/src/Xtb/CMakeLists.txt
@@ -31,7 +31,7 @@ set_target_properties(Xtb PROPERTIES
 target_link_libraries(Xtb
   PRIVATE
     Scine::UtilsOS
-    lib-xtb-static
+    xtb::xtb
     gfortran
   PUBLIC
     Scine::CoreHeaders

[weymutht]

Thanks a lot for reporting this. When doing a default build as explained in the README, we cannot reproduce your linking problems. Furthermore, after applying your patch, CMake fails with the following error:

CMake Error at src/Xtb/CMakeLists.txt:10 (add_library):
  Target "Xtb" links to target "xtb::xtb" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?