Coder Social home page Coder Social logo

Comments (80)

tgregerson avatar tgregerson commented on May 18, 2024 5

I've also been putting off switching from uTorrent due to this feature, so I finally broke down and started implementing it myself. I have a working prototype for a Tags system using the main GUI. Compared to Categories, the primary differences are:

  • A torrent can have any number of Tags.
  • Tags are unstructured. You can assign two tags to a torrent without needing one to be a child of the other.
  • Tags are just user-defined text metadata, and aren't linked to any other specific function in the system (unlike Categories, which map to save paths), so you can change tags without consequence.

Tags are intended to be as flexible as possible, so end users may utilize them for whatever niche use case they have. Personally, I have a hard time remembering whether I've actually listened to that album I downloaded, so I use tags to add a TODO to a torrent that I can remove when it's done.

Aside from that, they should be pretty familiar for users of Categories:
qbt-tags-all

qbt-tags-choose

Only simple single-tag filtering is possible right now, but you can get AND filtering in combination with the Category and Torrents filters:
qbt-tags-select

I also played around with a uTorrent-like approach of solving the Category -> Path mapping problem. Instead of having separate Category and Tags systems, you would just have a single "main" Category designated for a torrent and multiple "non-main" Categories, and only the main Category would be used to determine the save path. However I felt like this was more complex and confusing to users than logically separating Categories and Tags.

These features seemed like interesting future extensions, but not necessary for the initial implementation:

  • Ability to select multiple tags in the filter widget and do AND / OR filtering
  • Facility for adding / removing multiple tags in a single action
  • Support for defining rules to auto-assign tags

Feedback is welcome.

from qbittorrent.

WillfulChild avatar WillfulChild commented on May 18, 2024 4

After switching from utorrent, I'm finding the lack of multiple labels a significant handicap. Why not have a primary label for save path, and allow multiple secondary labels, like utorrent does?

from qbittorrent.

nivensd avatar nivensd commented on May 18, 2024 2

With Linux/UNIX systems, at least, a hard or soft link could be utilized to have the torrent files in both folders. Hard link would be preferable, as removing a tag from a torrent would mean just deleting one of multiple pointers to a storage address, versus the soft linking requiring a move of files before the original is deleted.

Example:
Torrent a gets downloaded and tagged with both "StuffILike" and "StuffXLikes". Original files go in folder "StuffILike" and soft link goes in "StuffXLikes". Now if you remove the tag "StuffILike", you must now delete the soft link and move the original files to "StuffXLikes", as the soft link points to location in the directory "StuffILike".

Versus creating a hard link which points to the actual location on the disk.

from qbittorrent.

buinsky avatar buinsky commented on May 18, 2024 2

23

@qbittorrent/qbittorrent-frequent-contributors

Should the labels system be redesigned in such a way? What do you think?

from qbittorrent.

buinsky avatar buinsky commented on May 18, 2024 1

@glassez Will be main label which will be assigned to torrent (like in uTorrent). It will displayed in labels collumn like label1/sublabel1/sublabel2 . Each label will have default save path ({default save path}/{label path}). Will be ability to assign custom path per label. Selected item of the tree will be used as label filter. Checked state of the tree items will be changed according to selected torrents:

  • checked if label assigned to all of selected torrents;
  • unchecked if label is not assigned to any of selected torrents;
  • indeterminate if label assigned to part of selected torrents.

from qbittorrent.

JinxDojo avatar JinxDojo commented on May 18, 2024 1

@ALL: Please consider creating a new, separate thread for "save path" issues; this thread was and should be about assigning labels. As I said last November: we have let this get far too muddled in the save path issue--unnecessarily.

All we need is a simple "tag" system for UI selection. That is much more fundamental and is all this thread should be focused on. We do not need a hierarchy of labels. We do not need to worry about advanced saving paths. As has been stated above: if a label really must be associated with a save path, let each torrent have a "primary" label (or call it a "category"--with the distinction that torrents automatically inherit attributes from their "category").

Personally, I don't see why a label should even be associated with a save path in the first place. Each torrent has its own save path stored in memory. Whatever assigns the label could just as well assign the save path, no? Perhaps we could consider just eliminating the label:save-path relationship?

Regardless, discussing ways of handling the save path much further than what's necessary to enable the label system does not seem beneficial/appropriate for this thread, which is about assigning multiple labels ("tags"). We need to clarify this issue if we're ever going to get something implemented.

from qbittorrent.

mesvam avatar mesvam commented on May 18, 2024 1

It seems @glassez was planning on implementing a tagging subsystem as a part of #4696 back in January.

Is that still part of the plan? #4784 shows as merged without the feature.

from qbittorrent.

cdumez avatar cdumez commented on May 18, 2024

Would indeed make sense. The issue lies in the "Append label to save path feature". I'm still not sure how to support both features.

from qbittorrent.

drakkenson avatar drakkenson commented on May 18, 2024

Perhaps making each label become a folderwithin the folder of the preceding label. This would also need a way to change the order of the labels for a given torrent.

from qbittorrent.

Gelmir avatar Gelmir commented on May 18, 2024

Hard links will be pain in the ass to manage on multiplatform.
NTFS supports hard links, not sure about FAT.
Qt has QFile::link, but it will only create soflinks ( which are .lnk shortcuts on Windows). So this approach will require platform-dependent code; and don't forget about OS/2 port.

Using subfolders for each label is not ideal either: we cannot predict what label will be assigned first, second, third, etc. And some users may prefer a strict folder hierarchy for multi-label.

My suggestion: use a master label (which will be appended to path); other labels will not contribute to path expansion.

from qbittorrent.

GitHub-devel avatar GitHub-devel commented on May 18, 2024

I used this in uTorrent - it really helps for organizing your torrents.

from qbittorrent.

Belove0 avatar Belove0 commented on May 18, 2024

I commented on a newer repeat post of this feature request already;
It's very handy -
uTorrents solution is to have a main label (and other labels). The main label is used for the save path feature. The main label can be changed with right-click menu (other labels can too, I forget exactly what the menu structure is).

This also calls for the ability to select multiple labels on the sidebar. uTorrents original behavior was to have "OR" (inclusive) logic when multi selcting with ctrl and shift, but, I understand, recently they added an option to use "AND" logic instead (which is the only logic I find useful for the way I use labels).

Thanks and good day to you :)

from qbittorrent.

Belove0 avatar Belove0 commented on May 18, 2024

Regarding hard links - yes NTFS supports them, but without Windows GUI features to manage them (at least one third-party plugin is available though).

FAT does not support them. There's no reference counter. You can cross-link files if you're especially clever, but CHKDSK will "fix" your work for you :).

The file system for Windows 8 I believe does away with both hard links AND symbolic links, but adds a new type of ".LNK" like file that behaves similar to symbolic links. This from my vague recollection from reading the release notes some time ago. So basically, forget hard links in Windows.

from qbittorrent.

jaredmcateer avatar jaredmcateer commented on May 18, 2024

When implementing this features I would like to recommend having a list of checkboxes rather than a dropdown for both the add torrent dialog as well as the RSS downloader.

It's a bit of a ux pain in the butt to have to choose a single label in the add dialog, then locate the torrent in the list and right click then navigate to labels then select another label (and repeat for all the labels you plan to add.)

It does add a bit more complexity if dealing with the primary label problem but you could always make it clear the first choice is the primary and then give an option for changing it.

from qbittorrent.

DancingDirty avatar DancingDirty commented on May 18, 2024

May I suggest a double labeling-tagging system? so you keep the labeling system AS IT IS, BUT you ADD-CREATE a new system that you call it TAG/TAGGING something like that that you allow for only inner qBittorrent organisation of torrents.

So what I suggest:
1.Label system stays as it is (maybe rename to archive system or Filing system)
2.add a tagging system for inner qBittorrent torrent management

as "AsaRossoff commented 5 months ago"
""This also calls for the ability to select multiple labels on the sidebar. uTorrents original behavior was to have "OR" (inclusive) logic when multi selcting with ctrl and shift, but, I understand, recently they added an option to use "AND" logic instead (which is the only logic I find useful for the way I use labels)."" that should be impemented in my tagging system!

Also I am gonna make a new post about my idea (as it is kinda a new idea on the subject) in order to make it more popular!

from qbittorrent.

JinxDojo avatar JinxDojo commented on May 18, 2024

I would also like to see multiple labels/tags. @cdumez: simply make the first label "primary" and the rest auxiliary. While hard/symbolic links are an interesting idea, I don't think it is realistic for qBT to "force" a tag system into a hierarchal directory system--not without a tag-based filesystem.

Please don't let that issue stop you from adding multiple labels!

from qbittorrent.

Kervius avatar Kervius commented on May 18, 2024

Since this is the ticket about multiple labels, and in the context people often express need for hierarchical label tree (aka sublabels), allow me to dump an idea here.

If QBT implements sublabels/label tree, then there is an interesting opportunity: when sorting torrents by label, show the label tree right inside the torrent list. (IIRC Qt's listview supports that right out of the box.) In spirit, that is very similar to how QBT shows the batch torrents with subdirectories.

That would keep the UI still simple, since there is no need to change the UI paradigm to make space for the tree.

Bonus feature: collapsing/folding a label would hide the torrents assigned to it.

FYI.

from qbittorrent.

buinsky avatar buinsky commented on May 18, 2024

@sledgehammer999 What if I will redesign labels system to look above? This can close multi-labels per torrent and sublabels feature requests.

from qbittorrent.

glassez avatar glassez commented on May 18, 2024

@buinsky I think you will not be difficult to implement the assignment of the labels to torrents. But what to do with what the labels needed? I mean, sorting, filtering, and effects on the save path. Have you thought about this? Leave the description.

from qbittorrent.

glassez avatar glassez commented on May 18, 2024

It is clear (in theory - wait implementation).
But you have mentioned about multi-labels per torrent. What about this?

from qbittorrent.

buinsky avatar buinsky commented on May 18, 2024

It is clear (in theory - wait implementation).
But you have mentioned about multi-labels per torrent. What about this?

If you will check several labels they will be assigned to selected torrents.

from qbittorrent.

glassez avatar glassez commented on May 18, 2024

And the sort? It will be only one of them? On the main? Then what the label will be the main one - the first assigned?

from qbittorrent.

buinsky avatar buinsky commented on May 18, 2024

Sort will use the main label. By default the main label will be the first assigned label but you will be able to select the main label.

from qbittorrent.

sledgehammer999 avatar sledgehammer999 commented on May 18, 2024

You should read #917 it has some ideas too.
I had similar thoughts about this just like buinsky.
But a little bit different:

  1. Rename current "labels" to "categories". Only one category per torrent. Then introduce the concept of "tags". Each torrent can have many tags. This solves filtering and sorting but not saving to disk. In this case only the category can be used for the save path.
  2. One other solution is to just have multiple labels. The save path is built by the order the user assigned each label eg "save_path/label2/label5/label1". So 2 torrents might have the same labels attached but end up in different places(I don't think this is very desirable). We then have a dialog box that lets the user rearrange the order of the assigned labels.(and then we rebuilt the savepath and move the files to the new path). However in this system the only way to implement "associate a path with each label" is to this hack: if a torrent has only one label use the label's assigned path, if more labels are assigned either dump the files in the save_path or to save_path/label1/label22.

IMO, we can't implement everything. Some of the requested will be dropped.
If I have understood the many users that have complained about the labeling system in the bug tracker and in the forum, their first priority is "I want to assign more labels to a torrent" and not "I want to have multiple labels to construct the save path".

So, IMO, the best solution is category+tags (or main label+ sub labels as buinsky named it). However, the current system of constructing the save path from the label should be dropped. Instead the user can assign a path to each category.

The above isn't a decision on what to do as a project manager. It is observations and proposed solutions at this point.
Now I'll attempt to make a list of what people want with labels. This will make easier the discussion for ANY proposed action.

  • multiple labels per torrent
  • multiple labels per torrent that can be used to construct the save_path
  • assigning a path to each label
  • selecting multiple labels from the side-pane to filter the torrents in the transferlist

PS: I re-read buinsky's proposal and I think it is very similar to my conclusion. However about the checkboxes: If we just allow multiselecting in the side pane wouldn't that suffice? -because checkboxes look ugly there-

from qbittorrent.

buinsky avatar buinsky commented on May 18, 2024

-because checkboxes look ugly there-

@sledgehammer999
OK. Then another variant:

  1. remove checkboxes
  2. rename labels to category
  3. add tags

It would be nice if the category of selected torrent(s) will stand out (for example with asterisk at the end). It will look like this:

23

from qbittorrent.

sledgehammer999 avatar sledgehammer999 commented on May 18, 2024

What is the use of asterisk?
Is your variant the same as mine? (I suggested one category-multiple tags)

from qbittorrent.

glassez avatar glassez commented on May 18, 2024

It is possible, I also try to organize here?

  1. Categories - something like virtual directory structure. You can set the save path for each category, or use the automatic save path based on the full name of category or not to use it - depending on settings. There is only one category for torrent. We can sort and filter by categories (only need to determine whether the filter to act on the subcategories or not). "No category" is also a category (without the possibility of changes and add subcategories). "All categories" - the categories tree root (top level category; without the possibility of changes and add torrents).
  2. Tags - simple text tags. You can assign the torrent any number of tags (or none). We can only filter by tags (but can't sort).

from qbittorrent.

sledgehammer999 avatar sledgehammer999 commented on May 18, 2024

@glassez I am confused. You say one category per torrent but then you talk about subcategories. In my mind these are mutually exclusive things.

from qbittorrent.

glassez avatar glassez commented on May 18, 2024

I spend a mapping to the directory structure of the file system. When I say "only one category", I mean "only one path". This does not exclude subcategories. For example, the torrent can be either in Category1, or in Category2, or in Category1/Category13, or in Category2/Category24/Category243, but not in few of them at the same time. As a file in the file system - it can only be in one place (not including links).

from qbittorrent.

sledgehammer999 avatar sledgehammer999 commented on May 18, 2024

I thing I get what you're saying. But in this case, aren't tags useless?

from qbittorrent.

glassez avatar glassez commented on May 18, 2024

Possible.
I would have done so... First I would implement Categories with all their features and have looked at user reviews. If they need something else, it will be possible to consider it then.

from qbittorrent.

buinsky avatar buinsky commented on May 18, 2024

It is clear (in theory - wait implementation).

@glassez В коде такая мешанина, что капец...

from qbittorrent.

glassez avatar glassez commented on May 18, 2024

@buinsky Please speak English. It may be interesting not only for us.
In answer to your comment... (it's gone for some reason)
Now I redesign QBtSession and QTorrentHandle. Because almost all of the rest of the code depends on this, I'll have to change it. I think that I could not prepare a workable PR sooner than a month. Maybe I will post a partial change earlier for review.

from qbittorrent.

sledgehammer999 avatar sledgehammer999 commented on May 18, 2024

Guys the past few days I was thinking about all said in here. Here are my conclusions.
Allowing to set a path per label is more preferable than the feature "append label to save path". So the feature "append label to save path" should be dropped in favor of custom paths per label.
Also, allowing sublabels is much more preferable than allowing multiple labels per torrents.
So, unless you have a good objection we should proceed with that. (I suspect that this was the original proposal of buinsky but I didn't understand it completely).
The only question I can think of at the moment is if we should limit the depth of sublabels? eg mainlabel->sublabel1->sublabel2->sublabel3->sublabel4?

from qbittorrent.

sledgehammer999 avatar sledgehammer999 commented on May 18, 2024

I forgot to mention that in the above scenario we don't need "tags".

from qbittorrent.

glassez avatar glassez commented on May 18, 2024

The only question I can think of at the moment is if we should limit the depth of sublabels? eg mainlabel->sublabel1->sublabel2->sublabel3->sublabel4?

IMO, Three levels should be enough.

from qbittorrent.

sledgehammer999 avatar sledgehammer999 commented on May 18, 2024

IMO, Three levels should be enough.

Just to be on the same page: You mean mainlabel->sublabel->sub-sublabel

from qbittorrent.

glassez avatar glassez commented on May 18, 2024

You mean mainlabel->sublabel->sub-sublabel

Yes.

from qbittorrent.

buinsky avatar buinsky commented on May 18, 2024

The only question I can think of at the moment is if we should limit the depth of sublabels?

What is the reason to limit the depth of sublabels?

from qbittorrent.

DancingDirty avatar DancingDirty commented on May 18, 2024

please do not drop the tag idea, being able to tag torrents means that two torrents might not be in the same category but share the same tag.

For eg:
you got a category videos and a category mods for which you use a path to save them so they are nicely in your drive, but lets say that the video is about or is a screencapture of a game and the mod is for the same game, you could make a tag in qbittorent so when you want to see what torrents you have about that game it would show the video and the mod!!!

from qbittorrent.

DancingDirty avatar DancingDirty commented on May 18, 2024

heavily edited, sry 😋 So sum up what I believe should be the outcome:

1.a way of putting torrents in organised folders (most here call it categories, I would title it filing and call it folders and subfolders) and no limit to how many to make! why limit them? should windows limit how many subfolders a user can make? NO :D

2.a way of tagging torrents so we can tag similar torrents to find them easily (even if the torrents are filed in different folders!) tagging would work like the torrent filtering that is already being done by selecting paused, active etc

For eg:
you got a category videos and a category mods for which you use a path to save them so they are nicely in your drive, but lets say that the video is about a game or is a screencapture of a game and the mod is for the same game, you could make a tag in qbittorent so when you want to see what torrents you have about that game it would show the video and the mod!!!

~radio buttons for categories/filing/folders
~checkboxes for tags
so user can assign category/filing/folder easily.

and it would look like buinsky previewed just I would propose also tags on top and filing in the bottom!

so here is my preview. 1.when a torrent is selected, green is the folder of the torrent 2.if multiple torrents selected that are in different folders, the folders are orange 3. when one torrent is selected, the tags of the torrent are green 3.when multiple torrents are selected, the tags that both torrents have are green, the other tags that some of the torrents have are orange.

the user for easy assignment of a folder or tag the next would happen 1. Selecting a torrent or torrents and clicking next to a folder in a radio button gray or orange assigns all torrents to that folder. 2. when selecting a torrent or torrents and clicking the gray or orange boxes next to the tags all torrents get assigned those tags, when clicking the green all torrents lose this tag.
asdfswefwsef

from qbittorrent.

JinxDojo avatar JinxDojo commented on May 18, 2024

If I have understood the many users that have complained about the labeling system in the bug tracker and in the forum, their first priority is "I want to assign more labels to a torrent" and not "I want to have multiple labels to construct the save path".

Yes. As another user stated: please do not drop the tag idea. Personally, I want to be able to assign labels (tags) based on a few parameters (e.g. audio/video/game, source of torrent/magnet, etc.). Then, I could CTRL+Select multiple labels (tags) on the left field to display just those items (no checkboxes or sublabel hierarchy needed).

I have little interest in the save paths, as I set those manually. Allowing a single-assignable category to control the save path is a fine idea. Trying to do so via tags/labels would require each tag/label to have its own properties, which seems beyond the scope of tags/labels (and more akin to "groups").

The number one goal should be the ability to select multiple labels and then apply properties to all of them at once. So, if I really wanted to adjust save paths, I could select tags "audio" and "SomeTorrentSite", then right click to adjust the save path for all selected torrents.

I realize this doesn't help so much with some of the automatic retrieval stuff, but I think that scenario should be secondary to the fundamental UI improvement provided by multiple labels/tags.

from qbittorrent.

sledgehammer999 avatar sledgehammer999 commented on May 18, 2024

Ok fair enough I see your use cases for tags. They should be included (if buinsky can implement them).
Depth of labels should be limited only if it is difficult codewise to work for infinite levels. (I doubt there is such a problem).
About the asterick: Do we really need it? The selected label will be highlighted anyway. (like it does right now).

from qbittorrent.

DancingDirty avatar DancingDirty commented on May 18, 2024

maybe reserve the "selected" category/folder for filtering perposes only. eg: when you see all torrents and have selected one torrent there should not be a category/folder selected because when a user selects a folder it should filter the torrent list to show only which torrents are in that selected category/folder!

and if you select a category which has subcategories, maybe torrents in the same categories should show up first and then sperated a bit all other torrents in the other subcategories... 🐹

from qbittorrent.

DancingDirty avatar DancingDirty commented on May 18, 2024

also can we split the discussion to a thread for categories/folders and a thread for tags cause are two different things and I want to put forward some ideas for tagging, like cntr+clicking on some tags should show all torrents assigned any of those tags and shift+some tags should show only which torrents have been assigned all selected tags! :D

from qbittorrent.

Belove0 avatar Belove0 commented on May 18, 2024

It's been a nerve-wracking few days (hehe) as I've followed this discussion... The feature is important to me, and I have limited time and resources right now to add to the discussion as much as I'd like. However, I mostly like where the discussion seems to be going at this point.

Goals?
  1. Filtering torrent list
    • To perform actions on or just view the state of a specific subset of torrents
  2. Setting/changing save path
    • For "Append the label of the torrent to the save path" option

User Interface & Interface Feature Suggestions

  1. List of "labels" for filtering (@ Transfers - sidebar)
    • Hierarchical / treeview (trying to keep compact horizontally for efficient use of space)
    • Multi-select (check marks are probably most obvious to user; but could simply toggle on click; or ctrl-click for toggling / regular click to select one and deselect all others)
    • If a "sticky" method of selecting multiple labels is used (e.g. check marks/check boxes or have single-click -- without ctrl -- toggle selection of a label without resetting the selection), include an option or method of resetting the selection. E.g., include an "(All)" item at the top of the list of labels.
    • Ability to toggle between inclusive (match any label -- "OR" logic) and exclusive (match all labels -- "AND" logic)
  2. List of "labels" for setting the selected labels for a torrent (@ Torrents - torrent - context menu)
    • Hierarchical (either using sub-menus, or "flattened" to a simple list... perhaps with dividers such as slashes)
    • Multi-select
    • Keep context menu visible while user is selecting multiple labels
    • Item to reset label selection to easily deselect all labels, e.g. "(none)"
    • Selection of label to use for "append to..save path" option (e.g., uTorrent uses Context Menu > Labels > Set Primary > {single-select list of labels})
    • (The requirements would be different if interface is elsewhere besides the context menu -- for example, a dedicated dialog window or a pane at the bottom of the Torrents tab)
  3. List of "labels" @ Add Torrent dialog
  4. List of "labels" @ RSS Downloader dialog

One system

  • I see no need to have two separate systems of "filing" the torrents.
Implicit filepaths
  • I see no need to explicitly assign filepaths to "labels" either;
    Instead, use our current method for the "Append the label of the torrent to the save path" feature of appending the actual text that constitutes the label to the path. With the labels in a hierarchy as I suggest, we can just separate the labels of the hierarchy with the OS path separator character (slash). The only issue is specifying which single label to use for this feature. uTorrent's solution is to have one label be called the "primary label", and that label is used for the "append to...save path" feature.
Hierarchy
  • I believe having the labels in a hierarchy significantly adds to their usefulness when filtering the torrent list, as labels naturally cluster to indicate different types of information. Being able to select a parent label to specify a broad category, when needed, instead of selecting 20 child labels that may be hard to identify when mixed with other labels is very useful, and creates a flexible system that user's can use to identify torrents based on many criteria and types of criteria when paired with multiple-selection, to suit their personalized needs.

from qbittorrent.

DancingDirty avatar DancingDirty commented on May 18, 2024

One system
I see no need to have two separate systems of "filing" the torrents.

the taggging system is not "filing" the torrents, its just a way to interact with torrents in qbt and filter them. the only reason we (me and some others) are talking about tags in this thread is because people ask for a way to assign multiple labels, which is not usefull when you can apend a path to a label that would mean that a torrent would reside in two paths/folders in the file system. So instead of messing with the labels functionality, labels would be an ideal way for "filing" torrents into the file system, and tags for in qbt managment

from qbittorrent.

JinxDojo avatar JinxDojo commented on May 18, 2024

I'm glad tags will still be considered. To avoid confusion, I recommend you follow your original idea and rename the primary/current/save-path-related label to "category" or "group" (especially the latter if you plan to have torrents automatically inherit other properties by being a member of that group).

What we have referred to here as tags (for clarification), G-mail et al call "labels"--so I think it might be confusing to keep calling the category/group a label. True: a rose by any other name would smell as sweet, but if you call it a "stink-bucket" people might not even bother to smell it!

Perhaps after a few versions have passed using only the terms tags and categories/groups, the term "label" can be reintroduced in place of tags.

Also, what AsaRossoff and DancingDirty wrote above regarding inclusive/exclusive filtering could be useful, but how easy would it be to implement in the UI without messy checkboxes? Shift+click often selects a range of items, so perhaps Alt+click could be used instead. Still: how would it be shown whether all tagged torrents are shown (inclusive) or only torrents with all the selected tags (exclusive). Perhaps a different selection color?

As I implied above (and I think most have agreed), we do definitely need two separate systems: one for selection/application and another for inheriting properties (e.g. save-path). I think the only way to avoid this would be to make some labels/tags have properties and some not, as labels/tags are inherently non-hierarchical, so precedence for properties could not be easily determined.

Small edit regarding categories/groups: If tags/labels are implemented, is there still a need to make the categories/groups hierarchical? The selection issues will no longer be relevant, and for setting properties (save-path)--as far as I can tell--users could do that themselves by naming categories "Category1.SubCategory11.SubSubCategory.111" etc. Is it an issue of horizontal display space? Or vertical? If vertical: is anyone really planning to have so many categories that collapsing/expanding sub-categories will be needed? I'm definitely not opposed to the idea, I just think it could be a bit confusing (both for the user and to code). For example: could sub-categories/groups override inherited values from their parent category? Are there plans to make categories/groups inherit any other properties (e.g. ratio/bandwidth limits)?

from qbittorrent.

buinsky avatar buinsky commented on May 18, 2024

What about such variant?

Remove tags from the filters widget.

Filtering:

filtering

Edit tags of the selected torrents:

menu

Edit tags dialog window:

dialog

from qbittorrent.

DancingDirty avatar DancingDirty commented on May 18, 2024

seems good, maybe the location of "edit tags" would be nice if it was in the bottom part as a tab next to "content"? and the dialog window down there? also how will you deal with multitorrent selection that have different tags? will you leave the tags that only some torrents have on the right side with different color?
or maybe like this:
sdrfghsrghdrthgdghd

edit: the extra idea I was going to comment here, I posted it as a seperate post #2559 aka [Wishlist] add custom saved search filtering - also advanced search

from qbittorrent.

sledgehammer999 avatar sledgehammer999 commented on May 18, 2024

Guys I am moving this to v3.3.0. I am a little bit focused on releasing v3.2.0 and I am not able to fully follow this discussion.
I'll try to respond the next few days.

from qbittorrent.

910nico avatar 910nico commented on May 18, 2024

@buinsky Thanks for your work :)

I really need this feature to limit download and upload speed, i'm seeding more than 10TB of files with several HDD.

Example for download: allow to limit the use of a HDD to prevent the 100% usage.(very big problem with optic fiber)

Example for upload : allow to limit each tracker for a better equality of seeding .

example :
Parent category ->"HDD 1" limited to 15MB/s
Child tag-> "Tracker 1" limited to 6 MB/s
Child tag-> "Tracker 2" limited to 6 MB/s
Child tag-> "Tracker 3" limited to 6 MB/s
Child tag-> "Tracker 4" limited to 6 MB/s

but the difficulty is other HDD can also contains this trackers
example :
Parent category ->"HDD 2" limited to 20MB/s
Child tag-> "Tracker 1" limited to 6 MB/s
Child tag-> "Tracker 2" limited to 6 MB/s
...
So a category should have a local effect but a tag should have a global effect and a category should have priority over a tag

from qbittorrent.

EraYaN avatar EraYaN commented on May 18, 2024

The way Tixati (1.99) does it is also pretty great (so you can set different ratio goal for different kind of stuff).
http://imgur.com/F4xiua2
Also they have a setup where every category has it's own paths.

from qbittorrent.

Namanati avatar Namanati commented on May 18, 2024

I agree I really like the system Tixati has set up, as you can make a category (label), and for each one set a download location, move location (which can be the same or different), and have them listed in categories of their own. Like in mine I have TV Series (Called a Separator in Tixati), with all my Series listed under it, each one automatically downloads to the correct location. In my case I have the download and move location the same, but those could different if a person needs to download to a faster drive and then move to a slower drive as an example. Clicking on the labels lets you see all the torrents under them. TV Series label list all TV Series, while the individual of course just list that particular series (i.e. Continuum). I have movies, music, software along with the TV Series, all stored on separate drives and/or directories, including network locations if needed.
tixati cats

from qbittorrent.

sledgehammer999 avatar sledgehammer999 commented on May 18, 2024

@ everyone here: This thread has become huge and now I am lost. Is anybody actively working on this? Speak so I can wait for you for v3.3.0. Otherwise, I won't consider this for fixing for v3.3.0.

from qbittorrent.

glassez avatar glassez commented on May 18, 2024

Speak so I can wait for you for v3.3.0.

I think you shouldn't do so. It's a very complex issue and we not come to the understanding of how it should be (not to mention some of the implementation).

from qbittorrent.

glassez avatar glassez commented on May 18, 2024

@sledgehammer999 Moreover, I don't think you should assign any milestone for this now.

from qbittorrent.

sledgehammer999 avatar sledgehammer999 commented on May 18, 2024

I think you shouldn't do so.

In case someone already has done work behind the scenes... I am not going to wait if he starts now.

from qbittorrent.

EraYaN avatar EraYaN commented on May 18, 2024

I seem to recall someone had a working implementation and also one working with the webui (I think he used that as a starting point, after it was said someone was building a multiple label/tagging system).

I can try to find it when I'm home if you want? I feel there might have been a PR already.

from qbittorrent.

sledgehammer999 avatar sledgehammer999 commented on May 18, 2024

The webui PR is already noted and almost ready for merging. The multi-label PR I cannot find. It probably was a proof-of-concept code residing in someone's repo, not as a PR.

from qbittorrent.

EraYaN avatar EraYaN commented on May 18, 2024

Yes I can't find it either. I think I have imagined it or mixed up fbarriga and/or ngosang (same guy?)

from qbittorrent.

glassez avatar glassez commented on May 18, 2024

@sledgehammer999, @EraYaN, as I said above, we have not yet concluded how this should work. What kind of implementation you are talking now?
Recall the basic problem of multiple labels:

  1. How the labels should be associated with the torrent? As a simple set of tags or some hierarchical structure?
  2. How will labels affect the torrent save path when 'Append label to save path' option is enabled?

from qbittorrent.

ngosang avatar ngosang commented on May 18, 2024

I think this feature is unnecessary for most users and we will have to change too many things to get this correctly implemented in the UI and in the WebUI.

  1. How the labels should be associated with the torrent? As a simple set of tags or some hierarchical structure?

I think a set or list of tags is enough.

  1. How will labels affect the torrent save path when 'Append label to save path' option is enabled?

I don't know. Maybe we can disable this option if multiple labels feature option is enabled. You can't have all things.

from qbittorrent.

glassez avatar glassez commented on May 18, 2024

I think this feature is unnecessary for most users and we will have to change too many things to get this correctly implemented in the UI and in the WebUI.

+1

You can't have all things.

+1
IMO, We can't please everyone at once. Moreover, users ' desires are often at odds with each other.

from qbittorrent.

sledgehammer999 avatar sledgehammer999 commented on May 18, 2024

Well, we can copy what others are doing and don't try to reinvent the wheel. And if we can't (or care) to implement that due to complexity... well there are a ton of other things we can implement in the bug tracker.

from qbittorrent.

JinxDojo avatar JinxDojo commented on May 18, 2024

In case this is something that is being worked on, I'd like to reiterate from my February 12th, 2015 post:

"The number one goal should be the ability to select multiple labels and then apply properties to all of them at once."

This is fundamental to the UI, and it is a use case that does not interfere with the other use cases (namely: the automatic save-path assignment). We have let this issue get muddled for too long, conflating the two major end-goals. It is not nearly as complex as it seems--if you stick with the goal of UI improvement. Labels/Tags are a priority!

By the way, if a tag system is implemented, and someone wants to edit save paths easily, he/she can mass select all members with that tag, and apply a new save path. I admit this isn't "automatic," but it demonstrates why the UI improvement supersedes the auto-save-path assignment, which should really be placed in another issue entirely.

As an aside: I tried in a previous post to articulate the difference between tags/labels and groups/categories, but I'm not sure if it stuck. Tags/labels are properties of a torrent, whereas groups/categories contain a torrent (and thus can apply properties to them). I think this is an important distinction to make when discussing this further.

from qbittorrent.

Danny3 avatar Danny3 commented on May 18, 2024

I'm curious about one thing,
Will it be possible, without chekckboxes to select mutiple non-consecutive labels only with the mouse?
In every user interface I've seen this is only possible using the other hand to press the CTRL key

Normally I'm using only the mouse to control the torrents and it would be nice not to be forced to use the keyboard if it's not really necessary

from qbittorrent.

mesvam avatar mesvam commented on May 18, 2024

If you're worried about complexity, is it possible to solve a simpler version of the problem? Something with just multi-label/tags, and selection by a single label, with no other fancy logic.

There's been a lot of good suggestions, but they're all more complex than necessary to solve the fundamental problem, which is the "ability to assign more than one label to a torrent." You can extend upon that later if you want to add label trees, check boxes, and/or logic, save path, primary/secondary labels, bandwidth limits, etc, but so many tasks would be exponentially easier, even with just a rudimentary multi-label system.

This is literally the oldest and also one of the most discussed issues of qBittorrent, and has been the only thing preventing me from switching to qBittorrent for years. It's pretty important to me (and evidently many others as well) to be able to label and select torrents in terms of both "tracker X" and "music" for example. Also two of the most popular clients uTorrent and Vuze have had this for a while. So I doubt it's an unpopular feature. Please, I'm begging you, just give us something... anything.

from qbittorrent.

Tsyko avatar Tsyko commented on May 18, 2024

Totally agree with @mesvam
The simplest possible solution would make me happy.

from qbittorrent.

 avatar commented on May 18, 2024

@sledgehammer999
Yo have moved my suggestion here but that's a wrong approach. Please read my comments:

"I talk about adding "/" as allowed character in labels so the program creates subfolders when moving downloaded torrents, not mentioned in any way having multiple labels."

No way my request is a duplicate of this thread. In fact is a totally different thing which has nothing to do with the mega-discussing here (even if someone mentioned it).

from qbittorrent.

FerdinandoLM avatar FerdinandoLM commented on May 18, 2024

as @Isabelxxx i'd really appreciate a way to create subfolders. I don't really need sublabels, but subfolders are a neat and clean way to store files.

from qbittorrent.

glassez avatar glassez commented on May 18, 2024

Guys, now I'm considering the implementation of Advanced Saving Management subsystem. It, in particular, will allow you to specify arbitrary paths (either relative or absolute) for labels.

from qbittorrent.

FerdinandoLM avatar FerdinandoLM commented on May 18, 2024

@glassez even better! So i don't necessarily have to keep the label name the same as the folder name.

from qbittorrent.

mesvam avatar mesvam commented on May 18, 2024

I would support a dichotomy of labels vs tags, as @JinxDojo has suggested. This would not require any change to existing behavior, so people can still use it for save path management if that's what they really want.

Personally, I don't see why a label should even be associated with a save path in the first place. Each torrent has its own save path stored in memory. Whatever assigns the label could just as well assign the save path, no? Perhaps we could consider just eliminating the label:save-path relationship?

I agree. When you add a torrent, it already prompts you for a save location. Using labels to further modify that path is redundant and makes it more confusing for me. What I would like is a tagging system, because there exists no workaround for this problem.

from qbittorrent.

EraYaN avatar EraYaN commented on May 18, 2024

The labels and seperate directories can be used for automation (different labels for different post processors)

from qbittorrent.

mribichich avatar mribichich commented on May 18, 2024

+1

from qbittorrent.

dogancelik avatar dogancelik commented on May 18, 2024

👍

from qbittorrent.

mesvam avatar mesvam commented on May 18, 2024

So are there no current plans for tags? Not even a rudimentary tag system? I've seen a lot of progress for subcategories.

from qbittorrent.

mesvam avatar mesvam commented on May 18, 2024

This looks perfect! Just what we've all been waiting for. Are you going to submit a pull request?

from qbittorrent.

tgregerson avatar tgregerson commented on May 18, 2024

Thanks for the kind words. You can see the PR linked above.

from qbittorrent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.