Coder Social home page Coder Social logo

Comments (4)

ezyang avatar ezyang commented on June 2, 2024 1

This probably needs a design doc

from pytorch.

jbschlosser avatar jbschlosser commented on June 2, 2024 1

From internal discussion: there is a preference towards avoiding actual serialization of dispatch-related args. We should store them as class properties instead -> query them from the cls arg within _make_wrapper_subclass(). This has a few benefits:

  • No need to change the serialization format
  • Decreased BC surface - serializing dispatch keys in particular is not something we want to do

We also discussed whether a default impl for subclasses that just works is valuable, as another option is to require a manual __reduce_ex__() impl for each new subclass. @albanD has the opinion that it is valuable and should be present; there are already quite a few things to think about for subclasses.

from pytorch.

ezyang avatar ezyang commented on June 2, 2024

What are you using the serialization for? Is it just multiprocessing?

from pytorch.

jbschlosser avatar jbschlosser commented on June 2, 2024

The serialization is used for both multiprocessing and torch.load() / torch.save():

pytorch/torch/_tensor.py

Lines 394 to 404 in 13462ec

arg_wrapper_subclass = (
type(self),
self.dtype,
tuple(self.size()),
self.stride(),
self.storage_offset(),
self.layout,
self.device,
self.requires_grad,
)
return (torch._utils._rebuild_wrapper_subclass, arg_wrapper_subclass)

from pytorch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.