Comments (4)
Thanks for the request. That sounds fair to me but we should really implement this in a way that is making the code more generic, not adding more if-statements along.
btw @guangyey should we add you to the cc list for module: xpu in #24422 to make sure you get cc-ed on these issues? Or should I add someone else in cc there?
Thanks, @albanD could you help add @gujinghui @EikanWang @fengyuan14, and @guangyey to cc list for module: xpu
.
from pytorch.
I've tried to implement this feature - see PR #125530.
from pytorch.
Thanks for the request.
That sounds fair to me but we should really implement this in a way that is making the code more generic, not adding more if-statements along.
btw @guangyey should we add you to the cc list for module: xpu in #24422 to make sure you get cc-ed on these issues? Or should I add someone else in cc there?
from pytorch.
That sounds fair to me but we should really implement this in a way that is making the code more generic, not adding more if-statements along.
I will gladly make changes to the PR #125530 I've posted if there is a consensus between maintainers on the direction. Please, start reviewing the PR and add notes on what you would like to see changed.
from pytorch.
Related Issues (20)
- ghstack and pytorch-bot can race
- Inductor lowerings for magic methods are suspicious
- "unhashable type: non-nested SymInt" error when using DTensor and Compiled Autograd together HOT 2
- torch.floor_divide throws floating point exception
- DISABLED test_cpp_extension_recommends_custom_ops_dynamic_shapes (__main__.DynamicShapesMiscTests) HOT 1
- DISABLED test_add_loggers_conv_bn_relu_fusion_quant (__main__.TestFXNumericSuiteNShadows) HOT 1
- W0603 torch/fx/experimental/symbolic_shapes.py:1325] [1/18] RecursionError HOT 9
- Inductor lowering ignores auto_functionalized custom op HOT 7
- GuardOnDataDependentSymNode: Could not guard on data-dependent expression HOT 7
- [dynamo] aten::sort() is not supported by dynamo_export
- Inductor lowering ignores auto_functionalized custom op HOT 2
- DISABLED test_cpp_extension_recommends_custom_ops (__main__.MiscTests) HOT 1
- Potential 7.5x compilation time improvement for foreach kernel HOT 5
- [torch.prod] Incorrect cpu calculation results for torch.prod HOT 3
- Missing build for 2.3.0 macosx x86_64 HOT 2
- [libtorch] `CppCommInterface` subclasses cannot be instantiated
- [Dynamo][TVM] make `opt_level` adjustable
- [ShapeInferenceError] Attribute dilations has incorrect size
- Segmentation fault in import_source.cpp during loading model via C++ API
- tensor.size does not accept `dim=None` argument despite documentation because of some confusion with named dimensions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pytorch.