Comments (9)
@serhiy-storchaka Do you have an example of such PR?
I usually look at documentation changes, so I'm not familiar with make regen-all
.
-
Is there a way to detect when
make regen-all
should be run? For example, what are the affected paths? -
Will it hurt if we run
make regen-all
for each backport?
Thanks :)
from miss-islington.
and should this be done even when using cherry-picker.py
command line?
from miss-islington.
The recent example: python/cpython#4118.
For running make regen-all
you need more than just git. First, you need to run ./configure
. For regenerating the grammar parser you need to build and run a special binary. All this takes a time. It is more efficient to run different commands depending on the files containing conflicts.
from miss-islington.
We're running the webservice in heroku, and I don't think we can run ./configure
from within heroku, it doesn't have the necessary software/libraries installed.
So I don't think we can do this.
from miss-islington.
I think https://github.com/heroku/heroku-buildpack-apt could work here.
Someone would need to run apt build-dep python3.7
on a system similar to Heroku to generate the list of required packages and write it to a file named «Aptfile».
Then the issue may be limitations (time) on background jobs or one-off dynos or whatever is used to run configure.
from miss-islington.
Time shouldn't be an issue. Backport jobs are all done in the worker dyno.
from miss-islington.
But I don't know a thing about the buildpack in Heroku..
from miss-islington.
I’ve used that buildpack (in addition to the base Python buildpack), would be happy to discuss setting it up!
from miss-islington.
perhaps even a custom merge driver could be written for this? (at least, specifically for the argument clinic files which is what I hit in python/cherry-picker#18)
and then the various cherry-picking / etc. tooling can use that merge driver?
from miss-islington.
Related Issues (20)
- 🚨 New Python runtime environment in Heroku HOT 1
- Backport fails with no explaination, but work if retried
- Missing Sentry in Celery env
- 🚨 New Python runtime environment in Heroku HOT 1
- Dependabot couldn't authenticate with https://pypi.python.org/simple/
- 🚨 New Python runtime environment in Heroku HOT 1
- bot spinning with automerge label HOT 3
- Respect existing co-author lines when backporting
- Prepare for the 3.10 beta release HOT 2
- Approved backport PR not merged whereas all CI tests passed HOT 6
- Duplicated Co-authored-by on backport PR merged manually HOT 1
- Backport PR no created HOT 2
- Bot can merge backport PR by miss-islington without core dev review HOT 8
- Islington reports status check being a success but also reports ❌ when checks fail HOT 2
- Miss Islington comments repeatedly with 🔨 test-with-buildbots "pending" status checks
- Automerge adds two empty lines to commit messages HOT 1
- Repeated status messages on merged PR HOT 6
- `miss-islington` merging unmergeable PRs HOT 1
- CLA status not transferred to backport PRs HOT 4
- Backport fails without any output HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from miss-islington.