Comments (10)
It is possible to set the committer explicitly for a commit, using git -c "user.name=Your Name" -c "user.email=Your email"
, and to extract committer information from the cherry-picked commit. It's not exactly straightforward, but I think GitHub should preserve the committer and author of the commit rather than the pull request. Maybe.
from miss-islington.
IMO, the use of co-author feature is a workaround (better than nothing of course, thanks!) I will report this to GitHub so let's keep the issue open for a while.
from miss-islington.
We can't preserve it in squash merge. Rebase merge maybe.
from miss-islington.
When we do squash merge into a single commit, GitHub takes the info of the PR author, not the original committer.
If we allow rebase merge, I think we can do the git -c "user.name=Your Name"
thing and the original author's info can be retained this way.
If the rebase merge is allowed, it will have to be enabled for all branches including master
. And the core dev merging a PR needs to know that for backport PR, use rebase merge option, for master
PRs, use the squash merge option.
from miss-islington.
By the way, I proposed allowing rebase merges when we discussed implementing a merge bot with @brettcannon and @Mariatta. They asked me to explain what exactly I'm proposing but I got sidetracked with other issues.
I can write a document and send it to core-workflow if you want to fix this issue.
from miss-islington.
GitHub just introduced Commit co-author feature. I'll investigate of how this can fit for miss-islington.
https://github.com/blog/2496-commit-together-with-co-authors
from miss-islington.
I tested the co-author feature in: python/cpython@6ea75b1
What do you all think about it? Would this be a good solution? I.e. having two co-authors to the commit?
I can code it such that the co-authored by
footer is always added in backport PR.
from miss-islington.
Co-authored-by
is now being added by default by miss-islington.
So I think it addressed your concern about preserving the author. The side effect is that they're sharing the credit with miss-islington.
Do you all think it's ok to close this issue now?
from miss-islington.
Just got a response from GitHub:
I can definitely understand how the ability to specify an author for a squashed PR merge might be useful. I've just added your +1 to that feature request internally. I can't say if or when a change will happen, but your feedback is in the right hands.
from miss-islington.
I consider this as won't fix, and closing the issue.
If GitHub will fix it soon, great, then there is nothing to do on our side.
If GitHub doesn't fix it, well, IMO the bot did make the PR, it can have the credit.
The co-authored by
line is sufficient to me.
from miss-islington.
Related Issues (20)
- 🚨 New Python runtime environment in Heroku HOT 1
- Backport fails with no explaination, but work if retried
- Missing Sentry in Celery env
- 🚨 New Python runtime environment in Heroku HOT 1
- Dependabot couldn't authenticate with https://pypi.python.org/simple/
- 🚨 New Python runtime environment in Heroku HOT 1
- bot spinning with automerge label HOT 3
- Respect existing co-author lines when backporting
- Prepare for the 3.10 beta release HOT 2
- Approved backport PR not merged whereas all CI tests passed HOT 6
- Duplicated Co-authored-by on backport PR merged manually HOT 1
- Backport PR no created HOT 2
- Bot can merge backport PR by miss-islington without core dev review HOT 8
- Islington reports status check being a success but also reports ❌ when checks fail HOT 2
- Miss Islington comments repeatedly with 🔨 test-with-buildbots "pending" status checks
- Automerge adds two empty lines to commit messages HOT 1
- Repeated status messages on merged PR HOT 6
- `miss-islington` merging unmergeable PRs HOT 1
- CLA status not transferred to backport PRs HOT 4
- Backport fails without any output HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from miss-islington.