[Bug]: transaction displays errors even if log_errors set to false about pyrevit

[kirsch33]

This is actually causing me some issues now so I've chosen your first option above and created a PR, open to feedback:

#2309

[kirsch33]

hey @sanzoghenzo

i am fine with either option and dont mind to submit a PR to address but would like some direction from another maintainer before doing so.

[sanzoghenzo]

Hi @kirsch33, thanks for pointing this out.
I've checked the history of that module and it seems it was always like that, maybe @eirannejad could shed some light on that.

But I agree with you, the name log_errors suggests that all the errors should/shouldn't be written.

We have some options here:

• if this is a bug, add the self._logerror check before the lines you pointed
• if this was an intended feature, add a log_commit_errors argument to the init and use that to suppress the logging, so that we keep retro-compatibility.

[kirsch33]

in the meantime, im trying to figure a workaround by completely suppressing all errors on a script level. i tried the following within a script that calls a pyRevit transaction:

logger = script.get_logger()
logger.set_quiet_mode()

but it doesnt seem to be working. any ideas @sanzoghenzo ?

[sanzoghenzo]

in the meantime, im trying to figure a workaround by completely suppressing all errors on a script level. i tried the following within a script that calls a pyRevit transaction:

logger = script.get_logger()
logger.set_quiet_mode()

but it doesnt seem to be working. any ideas @sanzoghenzo ?

What does print(logger.get_level()) outputs? It should show something like CRITICAL, a log level that is never used in the codebase

[kirsch33]

it outputs 50 which corresponds to CRITICAL and in the script if I try logger.error("test") it does not activate the logging window which is what I want.

but if something in the transaction wrapper errors, it will still display the error level message. maybe the transaction wrapper is using a different logger ?