Comments (14)
The extents of the crop is easy. If there is no crop the extents has to be calculated from the complete model and that is quite expensive.
from pyrevit.
It was intentional to use the level, because calculating a views outline can be tricky if it is not cropped. An alternative could be to use the view's outline if it is croped but fallback to the level's if it is not.
from pyrevit.
thanks, already fixed by 5ddd651
we always have our PBP at our internal origin, so never came accross this difference, but nice catch!
from pyrevit.
Manually, that makes me feel better to see the number of issues going down, that's me liking things tidyπ€
from pyrevit.
I'd prefer that method - and that's what I would expect (using the view's Associated Level if no Crop Region).
from the other thread:
maybe you could get the bounding box of the view instead? [though it would be nice,] If it's not precisely the outline of the crop region, that's fine (i.e. it can be rectangular), but sometimes our level is huge, but the plan view is smaller
from pyrevit.
I've changed the code to use the views extents. Do we need the level's extents as a fallback, or should the UI warn about turning on the crop? I think the different behaviour for uncropped views can be confusing without explanation, and most of the views are cropped anyway.
Thoughts? @RevitIRL @jmcouffin
from pyrevit.
@thumDer I'd go for the warning IMHO
from pyrevit.
I've also realized that I would need to combine that pre-check/warning with the 3d view's sectionbox check, because if the 3d view has a section box the script will use its extents for the planes, and the levels were only a fallback. So now the crop will be a fallback, and if there is none the warning will ask the user to turn on the section box OR the crop. Deal?
from pyrevit.
@thumDer deal
One thing I noticed is that in the Revit sample house (imperial) the plans are offset up by the inverse of the project base point vertical displacement
from pyrevit.
@jmcouffin Interesting. I don't have the imperial sample house right know, could you send it over to me somehow?
from pyrevit.
@jmcouffin Interesting. I don't have the imperial sample house right know, could you send it over to me somehow?
https://drive.google.com/file/d/1Vj5GuygVbzUShW91LJtvIp-ACSj20tkc/view?usp=sharing
from pyrevit.
shall we close the issue?
from pyrevit.
That fix I comitted is only for the elevation issue, I still need some time to finalize to crop based extents, only slight adjustments, safeguard mechanisms.
from pyrevit.
done. should we close this manually or let it close itself on next release?
from pyrevit.
Related Issues (20)
- show view range - enable for other view types (Sections, Details, etc. HOT 2
- show view range - account for Plan Regions HOT 3
- Add option to "Toggle All Grids Bubbles" to toggle bubbles at the sides of the view (top|bottom, left|right) HOT 2
- Automatically reduce the number of model faces HOT 6
- [Bug]: Installer installs an incorrect .addin file HOT 3
- Match properties does not work with text overides [Bug]:
- [Bug]: Sync View and Make Pattern tool not working properly HOT 5
- [Bug]: Pyrevit Error Load HOT 5
- [Bug]: Failure to Launch in Revit 2025 HOT 3
- Won't install in Revit 2024 HOT 2
- CLI Launches the wrong version of Revit [Bug]: HOT 6
- [Bug]: pyrevit Transaction crashes Revit 2024 when canceling occurred failure message HOT 4
- PyRevit does not work anymore HOT 5
- [Bug]: Make (Model) Pattern maker fail HOT 4
- [Bug]: Rename PDF Sheets not working
- Water and Airflow parameters - Sum total tool unit fix
- [Bug]: Color Splasher HOT 4
- [Bug]: Crash List installed Revits. HOT 4
- Wipe Option: Purge unused Revit Sheets which deletes all Sheets without Viewport on them except for the Sheet that I have open
- [Bug]: List Family Size error. crashes on Revit 2024 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyrevit.