pst_handler / #comments about pyemu

[jtwhite79]

def wanna support comments in the control file! Are your comments entire lines mixed in the DataFramed'd sections or extra things at the end of the lines? Can you upload you control file so I can add it to the tests?

[cnicol-gwlogic]

Awesome, thanks a lot. Comments are all end of line in my case, within the parameter and/or obs sections - I tested adding comment='#' to pd.read_csv() in _read_df() and it works fine with my file:
dualss_csgtrans_regwtsadj_v8_hp_dataworth_noregV3_base.zip
I guess it might be safest to add a parameter for users' comment character in calls to Pst()?

[jtwhite79]

Thanks for the file. I'll work on this - I was thinking it would be good to carry the comments through so that when you write a new control file it keeps them. This will take some more work but I think its important: I'm planning to start using the comments at the end of the lines to store metadata like spatial and temporal things...

[cnicol-gwlogic]

Ah good point, hadn't thought about re-writes, but yeah esp for monster files like this it is a nice touch.

[jtwhite79]

Ok, I think I got this going on the develop branch. By default, if comments are found during read, then they are repeated in a write. Let me know what you think.

[cnicol-gwlogic]

That works great - thanks a lot for implementing so quickly.

As an aside, I have noticed a couple of other issues with re-writes, probably quite specific to my setup. I'll have a stab at sorting them out in the next day or so and send you my suggested changes for consideration (let me know if that's not the easiest way to get these to you - I'm new to github).

Cheers,
Chris.

[jtwhite79]

I'm keen to hear any issues you have. Any contributions are welcome - pull request would be best.