Coder Social home page Coder Social logo

Comments (7)

hroncok avatar hroncok commented on May 29, 2024

The related Python 3.13 change is python/cpython#108125

from virtualenv.

hroncok avatar hroncok commented on May 29, 2024

Apparently:

$ virtualenv -p python3.13 testenv --no-seed --creator venv
created virtual environment CPython3.13.0.alpha.2-64 in 122ms
  creator Venv(dest=/home/churchyard/tmp/testenv, clear=False, no_vcs_ignore=False, global=False, describe=CPython3Posix)
  activators BashActivator,CShellActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator

$ cat testenv/.gitignore 
# Created by venv; see https://docs.python.org/3/library/venv.html
*

This either breaks the test expectation or virtualenv behavior.

Either we want the .gitignore file contents to be consistent (and hence we need to override it and/or opt-out of this feature) or we need to adjust the test to allow the venv-generated comment in it.

Which one do you prefer?

from virtualenv.

gaborbernat avatar gaborbernat commented on May 29, 2024

Either we want the .gitignore file contents to be consistent (and hence we need to override it and/or opt-out of this feature)

We want it to be consistent. Our ignore though should run after theirs, so we should overwrite what they create?

from virtualenv.

hroncok avatar hroncok commented on May 29, 2024

https://virtualenv.pypa.io/en/20.0.24/changelog.html#bugfixes-20-0-24

Do not generate/overwrite .gitignore if it already exists at destination path - by @gaborbernat. (#1862)

from virtualenv.

hroncok avatar hroncok commented on May 29, 2024

86deb12

from virtualenv.

gaborbernat avatar gaborbernat commented on May 29, 2024

Huh! I think we should probably just adjust the test and also make sure that what we generate looks like what venv generates (mostly).

from virtualenv.

hroncok avatar hroncok commented on May 29, 2024

I started by #2672

The files only differ by the comment.

from virtualenv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.