Coder Social home page Coder Social logo

Comments (14)

ryneeverett avatar ryneeverett commented on July 21, 2024 5

Can't we avoid an overloaded term like "lock" altogether? How about Pipfile.freeze?

from pipfile.

kennethreitz avatar kennethreitz commented on July 21, 2024 4

@jacebrowning i love your recommendation, and may use these names. @glyph, I was generally opposed to your feedback until I saw these name suggestions. I think they're great.

from pipfile.

jacebrowning avatar jacebrowning commented on July 21, 2024 3

What about requirements.pip and requirements.piplock?

from pipfile.

Tatsh avatar Tatsh commented on July 21, 2024 3

I say since Pipfile is Python code, then it should just end in .py. And similarly, use .json on the lock file. I don't see a reason to avoid the generic extensions. You could even use .lock.json.

.lock.json has no real precedence, but using the generic extension does: composer.json, package.json.

├── pip.py
├── pip.lock.json
└── setup.py

from pipfile.

glyph avatar glyph commented on July 21, 2024 3

@kennethreitz I should have been clearer that my extension suggestions were somewhat intentional strawmen. I'm glad that others stepped up and came up with better names!

from pipfile.

sethmlarson avatar sethmlarson commented on July 21, 2024 3

As long as the .lock extension was done away with I am fine with any decision. :) Completely agree with Pipfile and Pipfile.freeze.

from pipfile.

sethmlarson avatar sethmlarson commented on July 21, 2024 3

@dstufft .lock just makes me scared to delete it because it makes me think that another process is using it as a file mutex or something. Having .freeze makes me feel a lot more safe in deleting it. I think this thought is shared by more than me?

from pipfile.

kennethreitz avatar kennethreitz commented on July 21, 2024 2

@jacebrowning your feedback has been incorporated into the document.

@ryneeverett I like the idea of requiments.pip and requirements.freeze as well. I will heavily consider that.

from pipfile.

kennethreitz avatar kennethreitz commented on July 21, 2024 2

Updated to Pipfile and Pipfile.freeze in 15a1f0d

from pipfile.

reillysiemens avatar reillysiemens commented on July 21, 2024 1

FWIW, requirements.pip and requirements.freeze seem like much better names to me! Thanks @glyph, @jacebrowning, and @ryneeverett!

from pipfile.

dstufft avatar dstufft commented on July 21, 2024 1

I think that requirements.pip is a non-starter, since it's in common use today for what currently exists. I also don't think that Filefile is an antipattern, they've existed since the 1970's, if software can't handle them by now then maybe that software is just bad.

from pipfile.

sethmlarson avatar sethmlarson commented on July 21, 2024

I agree that the .lock extension is especially awkward.

from pipfile.

kennethreitz avatar kennethreitz commented on July 21, 2024

from pipfile.

dstufft avatar dstufft commented on July 21, 2024

I don't have an opinion on .lock vs .freeze, so I'm fine with either.

from pipfile.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.