Make this action play nicely with new gh upload/download artifact actions v4 about gh-action-pypi-publish

[alugowski]

One option would be to support a recursive scan of dist/, even if to only support one level. Currently the action complains about any subdirectory of dist. A recurse would allow directly chaining the download (like with v3), skipping that flatten step in my example. Then the only change needed to folks' workflows would be to add unique artifact names in the upload step.

[woodruffw]

FWIW, this restriction is inherited from twine: twine expects to be given one or more files, which this action does by tacking * onto the packages-dir input. The action itself isn't actually aware of nested directories.

[alugowski]

If using twine directly then tacking on */* works: https://github.com/scikit-build/cmake-python-distributions/pull/438/files

[webknjaz]

This is already solved in the download action. Not sure if I want extra pattern matching here.

[alugowski]

This is already solved in the download action. Not sure if I want extra pattern matching here.

Correct. Just to clarify, download-artifact just released v4.1 which includes a merge-multiple switch that does the flattening. Now this is sufficient:

      - uses: actions/download-artifact@v4
        with:
          path: dist
          merge-multiple: true

This is now just a documentation issue, to update the examples so folks know about this non-default switch.

[webknjaz]

This is now just a documentation issue, to update the examples so folks know about this non-default switch.

So this action doesn't showcase the use of matrices and other complex stuff. Neither does my PyPUG guide.
I suppose, it might be more useful to document it in cibuildwheel: pypa/cibuildwheel#1699.

[alugowski]

This is now just a documentation issue, to update the examples so folks know about this non-default switch.

So this action doesn't showcase the use of matrices and other complex stuff. Neither does my PyPUG guide. I suppose, it might be more useful to document it in cibuildwheel: pypa/cibuildwheel#1699.

Makes sense. I already have a PR for cibuildwheel docs: pypa/cibuildwheel#1705