sklearn.utils._weight_vector hidden import not found about pyinstaller-hooks-contrib

[bwoodsend]

Go ahead and make a pull request then...

[SiphonDuck]

I apologize, but I'm very new to Github and I don't honestly know how to do that, may you point me to some guide/manual or give me some directions on how to do that?
Thanks in advance.

[bwoodsend]

The guide is here at the moment but it's maybe best if I just do it then.

[SiphonDuck]

Perfect, thank you very much.

[bwoodsend]

Actually, #276 probably already fixed this. Can you retry with the development version?

pip install https://github.com/pyinstaller/pyinstaller-hooks-contrib/archive/master.zip

Then rebuild but add the --clean option.

[rokm]

Those warnings will be there even with #276, because that's an older hook that unconditionally adds those (now non-existant) hidden-imports.

I suppose a version check should be added to the hook (>= 0.21 based on comment, and < the version that renamed the modules); but sklearn.utils._weight_vector itself should be picked up without any additional changes, although probably by one of the newer scikit-learn hooks rather than this one (i.e., hook-sklearn.metrics.cluster.py).