Coder Social home page Coder Social logo

Comments (9)

pygy avatar pygy commented on September 18, 2024

Thanks for the suggestion.

I'm not opposed to changing the file organization, but I'd like to know why you would like me to change it.

The src directory is intended for development, the aggregate lulpeg.lua for public consumption.

My current dev workflow is pretty ad hoc, and I would probably gain by using common tools like lake, for example.

Do you have any suggestion in that regard?

from lulpeg.

moteus avatar moteus commented on September 18, 2024

Sorry. I do not understand how build this module.

PS. It fail with my pop3.message grammar.

lulpeg.lua:1623: attempt to index local 'cap' (a nil value)

from lulpeg.

pygy avatar pygy commented on September 18, 2024

Sorry. I do not understand how build this module.

Please don't apologize, I'm at fault here. Sorry for the lack of documentation. Run ./scripts/make.sh from the LuLPeg directory.

This is off course a bug, I'm investigating. Thanks for the report.

from lulpeg.

moteus avatar moteus commented on September 18, 2024

I already find it, but i work on Windows and use cmd not bash :). Thanks.
May be you should remove lualpeg.lua from git. When i run
luajit ..\scripts\pack.lua > ..\lulpeg.lua i got different file.
Or may be you can use git hooks to build it, but i have no idea is it possible at all.

from lulpeg.

pygy avatar pygy commented on September 18, 2024

The bug is fixed. Named groups were always incrementing the capture count, even if their match had failed. This resulted in holes in the capture accumulator, where none should have been.

I've added your pop3 tests to my regression test suite (with due attribution). It should help prevent regressions.

I already find it, but i work on Windows and use cmd not bash :). Thanks. May be you should remove lualpeg.lua from git.

I need to improve the build process... I prefer to keep the packed file, at least at the moment.

When i run luajit ..\scripts\pack.lua > ..\lulpeg.lua i got different file.

What do you mean by different? Is it working? Maybe I forgot to build it for the revision you tried?

I'll have a look at git hooks, thanks for the suggestion.

from lulpeg.

moteus avatar moteus commented on September 18, 2024

What do you mean by different? Is it working?

I mean it different from https://github.com/pygy/LuLPeg/blob/master/lulpeg.lua

from lulpeg.

pygy avatar pygy commented on September 18, 2024

Could you post a diff?

from lulpeg.

moteus avatar moteus commented on September 18, 2024

:) it was different order of modules and \r\n instead of \n

from lulpeg.

pygy avatar pygy commented on September 18, 2024

Cool :-)

I really need to streamline the packer.

from lulpeg.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.