Comments (6)
I would not assume it is the same ship. There were cases when ship stats differ (after t1 hull rebalance, vanity variation wasn't updated, e.g. ishukone watch scorpion). Thus hybrid approach won't be a very good idea.
from pyfa.
Point noted, that would require us to trust CCP to update accordingly. -_-
A custom group would seem to be the best course of action, then, unless there is objection. I've got a local branch with these changes - currently with all vanity ships noted in the market service. However, not all vanity ships are part of the new, replenish able skinned ships. Should we just include those that were added with Rubicon 1.3?
from pyfa.
It might be good solution, but short-term: i think chances that ccp will change painting approach rather sooner than later (to single typeID with multiple paint 'modules' or whatever). When they do it, we might need to do database conversion jobs which are always pain in the ass - both to prooftest and maintain in future.
Considering this, i would prefer 'mapping' to original typeIDs, even though it might be not very accurate in some edge cases (CCP probably even fixed ishukone scorp, i didn't check). This could also be used to maintain map of old names to typeIDs if we will want to support old module names for importing in future.
from pyfa.
Totally forgot about this issue. I think we need to do this at EOS level, so that way we can easily do the conversion from eos.getItem()
. I haven't looked at it, but we could simply import the map, and if found simply replace it and got from there.
We could also import the mapping into the market service so that we can force publish settings. I'll take another look at this soon.
from pyfa.
Actually, this was fairly easy: #97
Wasn't really sure where to put the conversion map, so I made a new file for it. And I'm also bad at naming files, so feel free to rename it to something better =3
from pyfa.
Just for the sake of documentation:
I suggest to move it to service layer, or at least move from DB-related eos part to fit importing part.
from pyfa.
Related Issues (20)
- Graph improvement: simulate defensive ewar in dps graph
- NotImplementedError python stacktrace upon app launch (Linux version) HOT 1
- Error while fetching ESI fittings
- Pyfa gives Gnosis 50% Mining drone bonus, in-game fitting does not. HOT 1
- No URL opening
- irreversibly disable MWD if toggled off
- Pyfa does not reopen fits on opening HOT 1
- ImportError in Debian GNU/Linux 11 (bullseye)
- copy to clipboard > ESF returns error HOT 2
- Dual monitor bug
- Double click in "Compare" mode resets column width
- Add button to search contracts for abyssal modules
- Lancer dreadnoughts still do not have a ship thumbnail
- deluge bonus missile good calculate?
- Unable to spawn a new child process: Failed to spawn child process HOT 1
- Pyfa Shows Up as a Virus Now HOT 1
- Boosts not applying properly, both projected and on boosting fit HOT 1
- Request: Folders for fits within ship type
- Where can I see the quality of the ship
- Ancillary armor repairers not displaying correct value.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyfa.