Slot ghosting about pyfa

[blitzmann]

Problem seems to be in eos.saveddata.fit.fill(), or at least partly. The real issue is that subsystems change the number of slots. In service.fit.appendModule(), pyfa compares the number of modules on fit before and after fill(). If those equate to each other, the fittingView never fires slotsChanged() which helps to refresh the GUI.

On my Loki, I have any subsystem for the other slots. For the Propulsion, all the modules have +1 to low slots, whereas the Nullifier does not. This means that if you have a fit that has one empty slot, then you might have 23 modules to 24 slots. If you switch to the Nullifier, the number of slots decrements -1, but the number of modules stay the same. Since they equate each other, it never refreshes.

This problem does not occur if you have all the slots filled and then switch to the Nullifier. There are some other subsystems that do this, when the number of mods on the ship equates to the new number of slots when switching fits out.

It seems that this used to be a way to signal that we're dealing with a t3 cruiser - if the comparison does not equate, then the slots must have changed, and so we fire off the slotsChanged. But there are edge cases where this does not work.

I will be submitting a pull request to simply call slotsChanged regardless to cover our bases. I've tested this with t3 and regular ships with no signs of regression, so from what I've noticed it's not harmful to call this with every ship (I'll also be removing it from removeModule for in-case purposes)

[blitzmann]

fixed 752b1fe