Need traits back please about pyfa

I'm trying to add a tab onto the ship basic stats to show ships' traits. Hopefully I can get it working in the next few days and get it merged in.

[kylinblue]

tyvm, I have a few more feature request should I open a new issue?

1. Make the loadout tab able to pull out from main window and become a new window, just like pulling out a tab from Chrome browser. i.e. Benefits users who have large screen or dual screen.
2. Add an option that allows you to copy partial loadout of modules to another loadout, when pressed Ctrl+C. i.e. Copy some modules from a T1 ship loadout to its pirate variation loadout instead of add all those modules again.
3. Overheat timer.
4. The remote feature similar to this. http://o.smium.org/loadout/4332#remote But it might come out tons of trouble and bugs. :(

[blitzmann]

Traits were removed from the text of ship descriptions in Rubicon 1.1 due to CCP. It's not as trivial to get the back into the game due to the way the database is set up, unless CCP has fixed this recently. If @cl05tomp is able to make a pull request it would be a great improvement

1. I have no idea how difficult this would be. Would it open up a completely new pyfa instance ala Chrome? Would it open up a loadout with just the stats on the right? This sounds like a major refactoring to the ui code, might be possible when work is started on new pyfa version

2. Overheat is chance-based. It's difficult to say "This module will last XmXs on overheat" due to that chance.

3. That's nifty, never knew osmium had that. I think the new EOS engine is supposed to handle projection effects a lot better, so something like this might wait for new pyfa version

The static db that CCP shipped was missing the invTraits table, so I added the missing table into eve.db -- now I just need to match up the bonuses with the ships.

[blitzmann]

Did they release a invTraits table? Or is it a community table? Last I heard CCP were 'looking into it'

CCP released a new SDE, see https://forums.eveonline.com/default.aspx?g=posts&m=4172020#post4172020

[DarkFenX]

I will put them back to description this weekend (i hope i will have time for it). We do not use official data exports, thus it's not super-easy, i will have to rewrite data dumping / conversion scripts.

[blitzmann]

I would actually like to see them in their own tab if possible. Keeps the clutter low. @cl05tomp how close are you to being done with your additions?

I'm hoping to have it done tonight or the latest tomorrow. I also like having the traits in their own tabs and it keeps parity between Pyfa and the in-game show info. I've put the trait tab before the description tab, just like it is in-game.

[kylinblue]

About the "Chrome multi-tab style":
Solved by opening another pyfa instance. :P

[blitzmann]

@kylinblue Brilliant!

Almost done! Just gotta add the "per-level" descriptions and make sure traits only show up for items that have it (i.e. only ships)

[DarkFenX]

cl05tomp, i agree it should be in separate tab. But still, i won't have any spare time till this sunday to write anything myself / review any suggestions.

As for how to process traits - see reverence (https://github.com/ntt/reverence/blob/master/examples/traits.py), it contains example script for exactly this use-case. I just need to integrate it into existing scripts or write new one.

Success! I'll get a pull request after another look over all ships tomorrow.

[blitzmann]

Well now you're just teasing. ;)

[DarkFenX]

Done. I had to rework implementations to integrate with phobos & to show them in predictable (and correct) order though.

[DarkFenX]

Will make a release tomorrow.