Coder Social home page Coder Social logo

Why is Chardet a dependency? about pyexcel HOT 3 OPEN

dhensen avatar dhensen commented on May 28, 2024
Why is Chardet a dependency?

from pyexcel.

Comments (3)

dhensen avatar dhensen commented on May 28, 2024 1

@chfw I think I know what happened:
In #247 I think you were adding github workflows to run your tests, I think your pipeline then failed complaining about not having chardet.

I think you then added chardet to pyexcel/pyexcel, but this code is only used by pyexcel/pyexcel-io. I think it should have been added as a requirement for that package and not toplevel on pyexcel/pyexcel.

Our problem is that we (currently I work for a corporate fin. comp) can not use LGPL packages, so we can not use chardet.

To fix this:

  1. move dependency from pyexcel/pyexcel to pyexcel/pyexcel-io
  2. mark chardet for pyexcel/pyexcel-io as extras package
  3. try/except around import chardet and supply a basic encoding for csvz/tsvz zipfile encode guessing. I can do a PR for this

from pyexcel.

dhensen avatar dhensen commented on May 28, 2024

When searching for "chardet" in your whole organization I find a single occurence of chardet actually being used in python code:

https://github.com/pyexcel/pyexcel-io/blob/c7039124b2ab2d069f9955e38d10ac790c3c5389/pyexcel_io/readers/csvz.py#L46

note that this in pyexcel-io package

Did you maybe forget to move chardet to the requirements.txt for pyexcel-io? it's not in there.

from pyexcel.

dhensen avatar dhensen commented on May 28, 2024

@chfw if you have some spare time it would be really appreciated if you could take a look at this one

from pyexcel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.