Coder Social home page Coder Social logo

Comments (4)

pwr avatar pwr commented on July 17, 2024

The device index/type/register have to be matched anyway to recognize the reply (see lib/logitech/unifying_receiver/base.py:request()). Same goes when receiving an 0x8F reply. The initial request messages are also randomized whenever possible (usually HID++ 2.0 requests).

As for making the messages asynchronous, it would complicate the way the app works way too much. Usually when making a request, from whatever thread (and the Gtk GUI thread is the most sensitive to this), you need the reply right away to work with it.

Also, threading in python is... not great. Right now there's a separate thread just listening for events from the receiver/devices, the other requests are made in whatever thread needs the reply. In previous versions I've tried different solutions, and this one appears to work best so far, at least within the application.

from solaar.

pwr avatar pwr commented on July 17, 2024

Now that the 0.9 release is coming up, I've done a review of the behaviour of Solaar when solaar-cli is run in parallel. Tried listings, pairing and unpairing, and in all cases the state was correctly updated in the running Solaar.

If no more errors are reported by next week, will close this bug.

from solaar.

jrbenito avatar jrbenito commented on July 17, 2024

If no more errors are reported by next week, will close this bug.

Long time has passed. @Lekensteyn , is this still valid?

from solaar.

Lekensteyn avatar Lekensteyn commented on July 17, 2024

I guess that the matching of responses againsts requests should be sufficient.

from solaar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.