No "pyfiglet.fonts" module found about pyfiglet

[peterbrittain]

So, the question is what do you want to build by default and how do you propose to manage the two different builds....

It would be trivial to default builds to safe fonts by just renaming that directory to "fonts".

[Kraktorist]

The directory pyfiglet/fonts was removed for some reason. Maybe it's related to this issue #89 (Font licensing).
The one way to fix it is to create pyfiglet/fonts and put required fonts from pyfiglet/fonts-standard or/and pyfiglet/fonts-contrib to it.

[peterbrittain]

Yeah - I removed it so that we can build a package with all the fonts or just those that have a suitable license. You need to pick which by running make minimal or make full first. As you can see, that creates the required directory and populates it with the contents of one or both of the font dirs.

It's possible that there's a better way to specify that directly with setuptools, but I haven't looked as this project already used the Makefile.

[mkinney]

This should be fixed with #108

[pwaller]

@stefanor did you encounter this issue during #114 / #115, can anyone comment, does this remain an issue?

[peterbrittain]

The fix in #108 was definitely wrong. The whole point of the split was to separate cleanly licensed fonts from ones with a less clear license (so that Linux distros can just pick the clean fonts).

People using this codebase must use the makefile to decide which set they build. Looks like 114 still respects that logic.

[pwaller]

Thanks for commenting @peterbrittain.

Judging from the error it looks like it lay within the pkg_resources logic which was replaced in #114 so I think it should no longer be an issue.

[pwaller]

Revising what I wrote last night: I take it the issue would still be present in some form, since it requires a 'make' invocation.. I guess it might be worth having some logic to load from the other directories if they're there, if someone would like to try and implement a fix.

[peterbrittain]

It depends what you want to achieve.

The distro builders will still want some way to ensure that they just pick up licensed fonts (while others possibly just want everything), so you still need some way to make two different packages. With the legal requirements, you can't create one package with everything. This isn't really what setup.py is designed to do.

What's prompting the revisiting of this issue?

[pwaller]

It's that someone git clone'd the repository and finds that the software fails. In my mind, ideally it should work more or less as if you had installed it via a different route.

[peterbrittain]

Hopefully addressed by #122

[pwaller]

I'm going to close this as assumed fixed by #122, please ping this thread if you hit it again and I'll reopen, or file another issue.