Comments (11)
Actually, supporting icons from URLs that are not the parent/app site would be helpful too.
from pwabuilder-cli.
Thanks for making this suggestion. I added to the backlog.
from pwabuilder-cli.
Hey Voltages,
The more I think about your idea the more I like it. However I did some research and there is no indication that the spec will support that, and we are trying to stay within the scope of the manifest for the input. Would you like us to propose this to the spec working group? We will follow up with them either way
from pwabuilder-cli.
It should work, as that's controlled by CSP... so, so long as the CSP policy allows it, it should be doable
from pwabuilder-cli.
(having said that, I've not tested it in any implementations... I recommend trying this idea maybe in Chrome)
from pwabuilder-cli.
I'll try it out and see what I can find. My worry was with the whatwg icon spec and it's "external resource" text. I might just be reading too much into the wording though. If it's within the scope of the spec and especially if it's initial implementation supports it, we will add support.
I want to be cautions that ManifoldJS doesn't move some place contrary to the spec, as one of the goals is to increase adoption of the spec by both devs and user agents.
from pwabuilder-cli.
In the latest draft of the W3C manifest spec, we've removed the association with link rel=icon
(i.e., they are now completely different things and serve completely different purposes: the link rel=icon
of a page is for that page; while the icons
member in the manifest are for the application).
Can you clarify a bit more about what your concerns are? From an browser perspective, where one acquires the icon from is determined by the interaction of Fetch and CSP - so if there is nothing in the CSP preventing fetching and processing a data:
URL, then it should be no problem (so long as the format is one supported by the underlying OS)
from pwabuilder-cli.
Actually if you have removed the association with the link icon spec, that I have no concerns. I was trying to reconcile the two but I have always felt like the link icon spec was a bit "old world".
I like your tie it with CSP as well, I feel like we should make that part of the docs to encourage devs to implement CSP whenever enabling access to APIs (I think FFOS does this by design, but not a requirement for win10 or the Cordova pollyfilled apps)
from pwabuilder-cli.
According to the Microsoft Edge Web Platform Summit, packaged apps on Win 10 will have a default CSP policy:
script-src: ms-apps: data: 'unsafe-eval'; style-src ms-appx: data: 'unsafe-inline' object-src 'none'; font-src ms-appx: data:;
(local content is loaded through ms-appx-web:///)
from pwabuilder-cli.
Having said that, one should never explicitly write "ms-appx-web:///" in an app.
from pwabuilder-cli.
Is there an update on this? I'm trying to build a Cordova app with ManifoldCordova and was quite surprised that even file:// isn't supported.
from pwabuilder-cli.
Related Issues (20)
- Support local manifest HOT 1
- pwabuilder package command fails if the generated files are generated inside a folder named 'PWA'
- Cannot build windows10 appx. HOT 6
- Generating IOS package fails (500 error on the site, nodeback is not a function in cli) HOT 3
- Cannot build for Windows 10 HOT 1
- Web Bundle support HOT 3
- Big difference between CLI and webversion of PWABuilder? HOT 3
- [Question] Bot Test HOT 2
- Test HOT 2
- [Question] cordova-ios specific version HOT 2
- [Question] How do I set a custom android package name, version code and version name HOT 2
- Generate the iOS package with the latest PWABuilder CLI fails. HOT 2
- mismatch between directory structure generated by generate command and expected by run command for windows10 HOT 5
- Can't use pwabuilder to build for ios platform HOT 40
- Can't build Windows 10 package HOT 5
- pwabuilder-cli process not ending. How to use in build process? HOT 4
- Support for provisioning package ppkg based installation for Windows based PWA HOT 2
- Smart TV HOT 4
- Can we bring this to Fastlane so we can easily package our apps and submit to the store [New Idea] HOT 3
- How can I build my PWA for ios HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pwabuilder-cli.