Coder Social home page Coder Social logo

Comments (11)

 avatar commented on July 29, 2024

Actually, supporting icons from URLs that are not the parent/app site would be helpful too.

from pwabuilder-cli.

nbellocam avatar nbellocam commented on July 29, 2024

Thanks for making this suggestion. I added to the backlog.

from pwabuilder-cli.

boyofgreen avatar boyofgreen commented on July 29, 2024

Hey Voltages,
The more I think about your idea the more I like it. However I did some research and there is no indication that the spec will support that, and we are trying to stay within the scope of the manifest for the input. Would you like us to propose this to the spec working group? We will follow up with them either way

from pwabuilder-cli.

marcoscaceres avatar marcoscaceres commented on July 29, 2024

It should work, as that's controlled by CSP... so, so long as the CSP policy allows it, it should be doable 👍

from pwabuilder-cli.

marcoscaceres avatar marcoscaceres commented on July 29, 2024

(having said that, I've not tested it in any implementations... I recommend trying this idea maybe in Chrome)

from pwabuilder-cli.

boyofgreen avatar boyofgreen commented on July 29, 2024

I'll try it out and see what I can find. My worry was with the whatwg icon spec and it's "external resource" text. I might just be reading too much into the wording though. If it's within the scope of the spec and especially if it's initial implementation supports it, we will add support.
I want to be cautions that ManifoldJS doesn't move some place contrary to the spec, as one of the goals is to increase adoption of the spec by both devs and user agents.

from pwabuilder-cli.

marcoscaceres avatar marcoscaceres commented on July 29, 2024

In the latest draft of the W3C manifest spec, we've removed the association with link rel=icon (i.e., they are now completely different things and serve completely different purposes: the link rel=icon of a page is for that page; while the icons member in the manifest are for the application).

Can you clarify a bit more about what your concerns are? From an browser perspective, where one acquires the icon from is determined by the interaction of Fetch and CSP - so if there is nothing in the CSP preventing fetching and processing a data: URL, then it should be no problem (so long as the format is one supported by the underlying OS)

from pwabuilder-cli.

boyofgreen avatar boyofgreen commented on July 29, 2024

Actually if you have removed the association with the link icon spec, that I have no concerns. I was trying to reconcile the two but I have always felt like the link icon spec was a bit "old world".
I like your tie it with CSP as well, I feel like we should make that part of the docs to encourage devs to implement CSP whenever enabling access to APIs (I think FFOS does this by design, but not a requirement for win10 or the Cordova pollyfilled apps)

from pwabuilder-cli.

kenchris avatar kenchris commented on July 29, 2024

According to the Microsoft Edge Web Platform Summit, packaged apps on Win 10 will have a default CSP policy:

script-src: ms-apps: data: 'unsafe-eval'; style-src ms-appx: data: 'unsafe-inline' object-src 'none'; font-src ms-appx: data:;

(local content is loaded through ms-appx-web:///)

from pwabuilder-cli.

marcoscaceres avatar marcoscaceres commented on July 29, 2024

Having said that, one should never explicitly write "ms-appx-web:///" in an app.

from pwabuilder-cli.

colinfindlay-nz avatar colinfindlay-nz commented on July 29, 2024

Is there an update on this? I'm trying to build a Cordova app with ManifoldCordova and was quite surprised that even file:// isn't supported.

from pwabuilder-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.