Comments (15)
Hi Dave, we will review. Seems like a bug. Can you do me a favor? Can you rerun with the -l debug and shoot over the console?
from pwabuilder-cli.
@DaveVoyles
It is because of the new line \r on mac/unix machines. Do the following and it should be fine.
05/03/15 @ 4:15PM - kevincobain2000@Mac Air ~/Downloads cat /usr/local/bin/manifoldjs |col -b > temp;cp temp /usr/local/bin/manifoldjs
Note: I assume your manifoldjs is saved there --> /usr/local/bin/manifoldjs
other just do type manifoldjs
.
I think the problem is here ..? if you open https://github.com/manifoldjs/ManifoldJS/blob/master/manifoldjs.js#L1 in vim and check out the trailing new line char.
from pwabuilder-cli.
Kevin,
What does that command do? Which part of the commad should I be coppying?
from pwabuilder-cli.
@DaveVoyles Explained in #36
from pwabuilder-cli.
I see now, thanks.
So once that pull request is accepted, I can run npm -g install manifoldjs, and terminal will be able to locate the manifoldjs folder.
I'll hold tight until it is accepted
from pwabuilder-cli.
Are you seeing this issue when installing from github directly? (you can use npm install -g manifoldjs/manifoldjs
). Note: you may need to clean your npm cache.
from pwabuilder-cli.
That was the answer!
If you install with just:
npm install -g manifoldjs it does not install correctly.
I needed manifoldjs/manifoldjs
From there, I ran ManifoldJS http://www.DaveVoyles.com and it generated a package.
All went well, but it could be confusing to users when it reads:
WARNING: One or more tasks failed while generating the Cordova application
WARNING: One or more errors occured when generating the application
I know that this is becuase I'm on OSX and doing a build, therefore Windows will not be added to the platform. This is also likely a warning from Cordova, so there's not much you can do there.
Thanks for the tip! Works fine
from pwabuilder-cli.
If you install with just:
npm install -g manifoldjs it does not install correctly.
I needed manifoldjs/manifoldjs
Then the readme should be updated to reflect that. Let's reopen this issue to track that.
from pwabuilder-cli.
Actually, this will be fixed with the new release (v0.1.3). Installing the module from GitHub is just a temporary workaround, as well as for testing purposes. No need to reopen this issue
from pwabuilder-cli.
I just tried installing from the command line and got this error as well (v0.4.1).
Installing with npm install -g manifoldjs/manifoldjs
fixed it.
from pwabuilder-cli.
Will take a look. Thanks
from pwabuilder-cli.
Hi Trevor, I'm not able to re-create this on my pc. Are you using a mac by chance? can you tell me you os version and the NPM version you have installed?
from pwabuilder-cli.
Hi Trevor, I am able to see this on my mac as well, I think it's a line ending issue. Working on it
from pwabuilder-cli.
OSX 10.10.5
NPM 2.12.0
from pwabuilder-cli.
Yes, it seems to be related to the line endings: the manifoldjs.js
file within the published npm package has CR
+LF
as line endings instead of just LF
.
Even though the manifoldjs.js
file has the correct line endings in the repository (just LF
), there is a setting that defines how Git handles line endings –my guess it that the Git settings in the machine where the 0.4.1 package was generated is telling Git to convert line endings to CR
+LF
on checkout.
I generated a pull request to include a .gitattributes
that ensures to always use the correct line endings for the manifoldjs.js
file, regardless of the Git settings configured in the local machine. In order to fix this issue, I suggest to:
- Merge the pull request
- Clone the repo again
- Make sure that the
manifoldjs.js
file has the correct line endings (justLF
) - Publish a new version
from pwabuilder-cli.
Related Issues (20)
- Support local manifest HOT 1
- pwabuilder package command fails if the generated files are generated inside a folder named 'PWA'
- Cannot build windows10 appx. HOT 6
- Generating IOS package fails (500 error on the site, nodeback is not a function in cli) HOT 3
- Cannot build for Windows 10 HOT 1
- Web Bundle support HOT 3
- Big difference between CLI and webversion of PWABuilder? HOT 3
- [Question] Bot Test HOT 2
- Test HOT 2
- [Question] cordova-ios specific version HOT 2
- [Question] How do I set a custom android package name, version code and version name HOT 2
- Generate the iOS package with the latest PWABuilder CLI fails. HOT 2
- mismatch between directory structure generated by generate command and expected by run command for windows10 HOT 5
- Can't use pwabuilder to build for ios platform HOT 40
- Can't build Windows 10 package HOT 5
- pwabuilder-cli process not ending. How to use in build process? HOT 4
- Support for provisioning package ppkg based installation for Windows based PWA HOT 2
- Smart TV HOT 4
- Can we bring this to Fastlane so we can easily package our apps and submit to the store [New Idea] HOT 3
- How can I build my PWA for ios HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pwabuilder-cli.