Coder Social home page Coder Social logo

Comments (6)

pvolok avatar pvolok commented on May 20, 2024

I didn't change code related to those failing tests. The vt100 seems to be unmaintained, so at some point these tests might need to be fixed in this repo. But for now I think it's safe to ignore them.

from mprocs.

cyqsimon avatar cyqsimon commented on May 20, 2024

Okay good to hear. I was only concerned because I had packaged mprocs here, and I was having test failures (and therefore build failures). If you think it's okay I'll just go ahead and disable the tests.

Just out of curiosity, do you think it's likely that those faulty tests will be fixed/removed in the future, either by this fork of vt100 or upstream?

from mprocs.

pvolok avatar pvolok commented on May 20, 2024

After quickly checking a couple of failing tests, it is not clear which behavior is correct - expected or actual.

from mprocs.

cyqsimon avatar cyqsimon commented on May 20, 2024

Alright. I'll disable the tests for mprocs-vt100 and leave this issue open for now. Thanks for the assistance!

from mprocs.

GaetanLepage avatar GaetanLepage commented on May 20, 2024

Hello,
I tried to compile mprocs 0.6.3 and faced a compilation failure related to vt100.
Note: this is done within the nix ecosystem, but I think that the actual error is due to mprocs itself.

Here is the log I get: https://gist.github.com/GaetanLepage/431d34fe2eafe8480e0eca91101e96a2

Am I doing something wrong ?

Thank you very much for your help !

PS: Why does the mprocs crate indicates version 0.6.2 instead of 0.6.3 ?

from mprocs.

ptrcnull avatar ptrcnull commented on May 20, 2024

currently it looks like only one test fails:

---- bs stdout ----
thread 'bs' panicked at 'assertion failed: `(left == right)`
  left: `"faa\n baruux"`,
 right: `"faa\nbarx"`', vendor/vt100/tests/helpers/fixtures.rs:256:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

from mprocs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.