Issue with Any in OData $filter clause. about nhibernate.odata

[dsigitov]

Hi!

but would adding a line such as:
if (enumerableType == null) enumerableType = collectionType;
be acceptable? If it is, I'll get on and write a unit test and send a pull request.

I wouldn't recommend doing that. It will totally break the logic of this method.

The problem is that method doesn't handle correctly the case when collectionType is IEnumerable<T> itself.

Instead, change the method as follows:

public static System.Type TryGetCollectionItemType(System.Type collectionType)
{
    if (collectionType == null)
        return null;

    System.Type enumerableType;
    if (collectionType.IsGenericType && collectionType.GetGenericTypeDefinition() == typeof(IEnumerable<>))
        enumerableType = collectionType;
    else
        enumerableType = collectionType.GetInterfaces().FirstOrDefault(x => x.IsGenericType && x.GetGenericTypeDefinition() == typeof(IEnumerable<>));

    if (enumerableType == null)
        return null;

    return enumerableType.GetGenericArguments().Single();
}

It will first check whether the value of collectionType is IEnumerable<T> itself, then it will check all interfaces, so this test will pass:

Assert.AreEqual(typeof(int), OData.TypeUtil.TryGetCollectionItemType(typeof(IEnumerable<int>)));

[pvginkel]

Sorry for the late reply. I'll push a new version to NuGet in a moment with this fix.