Batch message sending does not add socket_id from event about pusher-http-php

[Justinas-Jurciukonis]

Where exactly it's thrown? And yes, most likely isset($event['socket_id']) should solve the issue.

[benjamin-tang-pusher]

#370 was merged, and the new version includes the socket id in batch trigger requests.

I will close this ticket. Thanks for bringing this to our attention.

[Justinas-Jurciukonis]

Also documentation is wrong. It states, that you must provide not indexed array as ['socket_id' => $socket_id], but code actually checks for $event['socket_id'] and not $event[0]['socket_id']

[benjamin-tang-pusher]

Hi, I will take a look at this. It's likely this is an oversight, since the readme shows passing ['socket_id' => $socket_id] with triggerBatch($batch).

[benjamin-tang-pusher]

The issue with adding adding socket_id back in at Pusher.php:1171 is that you don't always need to specify a socket_id, and if you don't, the library (correctly) throws a warning that PHP Warning: Undefined array key "socket_id" .

I need to ask around whats the best way of doing this. The (isset($event['socket_id'])) might be used for this.

[Justinas-Jurciukonis]

I see you have created PR for this issue.

To fix failing tests, replace assertObjectHasProperty with assertTrue(property_exists) (or update PHPUnit to 10.1 version)