Comments (6)
Where exactly it's thrown? And yes, most likely isset($event['socket_id'])
should solve the issue.
from pusher-http-php.
#370 was merged, and the new version includes the socket id in batch trigger requests.
I will close this ticket. Thanks for bringing this to our attention.
from pusher-http-php.
Also documentation is wrong. It states, that you must provide not indexed array as ['socket_id' => $socket_id]
, but code actually checks for $event['socket_id']
and not $event[0]['socket_id']
from pusher-http-php.
Hi, I will take a look at this. It's likely this is an oversight, since the readme shows passing ['socket_id' => $socket_id] with triggerBatch($batch).
from pusher-http-php.
The issue with adding adding socket_id back in at Pusher.php:1171 is that you don't always need to specify a socket_id, and if you don't, the library (correctly) throws a warning that PHP Warning: Undefined array key "socket_id"
.
I need to ask around whats the best way of doing this. The (isset($event['socket_id']))
might be used for this.
from pusher-http-php.
I see you have created PR for this issue.
To fix failing tests, replace assertObjectHasProperty
with assertTrue(property_exists)
(or update PHPUnit to 10.1 version)
from pusher-http-php.
Related Issues (20)
- Compatibility issues with ugprade 7.0.2 -> 7.2.0 HOT 11
- authenticateUser() gives invalid response HOT 6
- Echo.listen not working in pusher-php-server 7.2.1 HOT 2
- Upgrading from 7.0.2 to 7.2.0 breaks broadcasting events in laravel HOT 5
- Pusher error: cURL error 28: Failed to connect to api-eu.pusher.com port 443: Connection timed out HOT 7
- Invalid user id from pusher server. HOT 2
- The CI setup is not friendly to community contributors HOT 1
- Add the ability to set Guzzle config from $options HOT 3
- v7.2.1 is not compatible with pusher SDK HOT 5
- Internal Server Error 500 HOT 2
- Pusher Beams Enquiry HOT 23
- Reporting a vulnerability HOT 1
- Pusher being run at Laravel package:discover resulting in Argument Error HOT 7
- Pusher Presence Channel Data HOT 1
- First parameter must either be an object or the name of an existing class {"exception":"[object] (ErrorException(code: 0) HOT 2
- Question about deprecation for all of the versions above v13 HOT 1
- [bug] cannot set a custom timeout as a option in pusher
- Triggering single event on multiple encrypted channel fails HOT 1
- Pusher websocket URL triggering events and sending data HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pusher-http-php.