Coder Social home page Coder Social logo

Comments (7)

JoshOrndorff avatar JoshOrndorff commented on June 17, 2024

I've determined that we do not need a storage migration to reflect paritytech/substrate#9087 because the same string, TransactionPayment was used in both the old decl_storage! definition, and the construct_runtime! definition in each of the moonbase, moonbeam, moonshadow, and moonriver runtimes.

from moonbeam.

JoshOrndorff avatar JoshOrndorff commented on June 17, 2024

Also, the ticket includes a few things that we've already handled in previous dependency updates. Notably this one:

(paritytech/substrate#9102) double the allocator limit

from moonbeam.

JoshOrndorff avatar JoshOrndorff commented on June 17, 2024

Also the ticket is missing one that turned out to be quite relevant and is the reason for the broken evm tracing. paritytech/substrate#8953

from moonbeam.

crystalin avatar crystalin commented on June 17, 2024

@JoshOrndorff good catch,
@librelois can you check why the script didn't catch this PR ? I suspect it is the labels being filtered :/
(you can run the script locally, you don't need to trigger the CI).

from moonbeam.

librelois avatar librelois commented on June 17, 2024

Also the ticket is missing one that turned out to be quite relevant and is the reason for the broken evm tracing. paritytech/substrate#8953

@librelois can you check why the script didn't catch this PR ? I suspect it is the labels being filtered :/
(you can run the script locally, you don't need to trigger the CI).

No, it's not a label problem. This PR contains the label B5 which would pass the filter. The problem comes from the git tree of the substrate repository, this PR is not located between the tags polkadot-v0.9.7 and polkadot-v0.9.8. The corresponding commit does not appear here: paritytech/substrate@polkadot-v0.9.7...polkadot-v0.9.8

from moonbeam.

crystalin avatar crystalin commented on June 17, 2024

@librelois , It does appear there: the one before last:
image

from moonbeam.

librelois avatar librelois commented on June 17, 2024

My bad, I didn't find it with a ctrl+F (probably a mistyping). Anyway I have the same behavior when running the script locally, and this PR is not listed in the PR with the B5 tag, even before filtering by label.

from moonbeam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.