Data.String.null about purescript-strings

[LiamGoodacre]

I'm not sure this should be done.
I wouldn't advise passing null around pretending it's a string.
If a null check is added here, it'd be inconsistent not to check on every function.
The function Data.String.null is a check for if a string is empty, nothing to do with JavaString null.

[paf31]

Agreed, a null string as input is a sign something is wrong elsewhere.

[garyb]

Another 👎 - the value should be a Nullable String or read as a Maybe String or something before reaching the functions in here most likely.

[sharkdp]

I believe this can be closed?

[paf31]

Agreed, thanks.