Coder Social home page Coder Social logo

Host port setting is ignored about puphpet HOT 6 CLOSED

puphpet avatar puphpet commented on July 3, 2024
Host port setting is ignored

from puphpet.

Comments (6)

frastel avatar frastel commented on July 3, 2024

Ready for deployment

from puphpet.

jtreminio avatar jtreminio commented on July 3, 2024

Deployed!

from puphpet.

TSchuermans avatar TSchuermans commented on July 3, 2024

Tested, but still no rule in the Vagrantfile concerning the host port?

from puphpet.

frastel avatar frastel commented on July 3, 2024

Oops, ok will check it again in some minutes.

from puphpet.

jtreminio avatar jtreminio commented on July 3, 2024

@TSchuermans

Here's the relevant line of code:

{% if box.port_forward.guest is not empty and box.port_forward.host is not empty %}

You have to set both guest and host inputs, else it is ignored.

We could "fix" this by default port_forward guest to 80?

from puphpet.

frastel avatar frastel commented on July 3, 2024

Works4me. Port forwarding makes only sense when really two ports are given.

However I think we should re-think the current workflow. The user enters already the webserver's port in the vhost configuration. So the only thing missing here is to ask the user which port should be used to access the webserver on the host server. Avoiding the port forwarding directive completely to the user.

Besides we could add the port forwarding section for everything else but the webserver.

from puphpet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.