Coder Social home page Coder Social logo

Comments (5)

ezhlobo avatar ezhlobo commented on June 2, 2024

Hm, I made a mistake. It must be not possible to get any extra field from imported things, because babel does not resolve imports itself, or it will be extremely complicated. So we have only one way to do that: treat class names which start from up-case as a property always.

from babel-plugin-transform-react-pug.

ForbesLindesay avatar ForbesLindesay commented on June 2, 2024

The other option would be to use xml style namespacing:

React:Fragment
  Icons:Open
  Icons:Close

from babel-plugin-transform-react-pug.

ezhlobo avatar ezhlobo commented on June 2, 2024

@ForbesLindesay I like this option but I had been afraid that it might confuse, so I asked some feedback from my colleagues. No one was positive about this, mostly because it's unusual and not obvious.

For our purposes I created a separate plugin for babel which takes jsx and convert it to what we need by checking the first letter: ezhlobo/babel-plugin-transform-jsx-classname-components.

It requires more work on babel end, so it might be not ideal for everyone. So my final suggestion is not to do anything with this. But what thoughts do you have?

from babel-plugin-transform-react-pug.

ForbesLindesay avatar ForbesLindesay commented on June 2, 2024

I think on the whole, you can handle this by just doing const Fragment = React.Fragment; so it's probably fine to just leave this as is.

from babel-plugin-transform-react-pug.

ezhlobo avatar ezhlobo commented on June 2, 2024

Agreed.

from babel-plugin-transform-react-pug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.