ov50 -wxEVT_GRID_CELL_CHANGE depricated about findit_pi

[rgleason]

From polar_pi , same issue
ptulp/polar_pi#11

Maybe I should have been more specific:
In file PolarGui.cpp line 290, change 'wxEVT_GRID_CELL_CHANGE' to "
'wxEVT_GRID_CELL_CHANGED'
In file PolarGui.cpp line 312, change 'wxEVT_GRID_CELL_CHANGE' to "
'wxEVT_GRID_CELL_CHANGED'

In file Polar.cpp line 1159 change 'GetCols' to GetNumberCols'
In file Polar.cpp line 1159 change 'GetRows' to GetNumberRows'
In file Polar.cpp line 1159 change 'GetCols' to GetNumberCols'

Do NOT change file PolarDialog.cpp line 194, so leave that be
m_gridEdit->SetCellValue(event.GetRow(),event.GetCol(), s);

[rgleason]

Change
gui.cpp Line 315, 323, 329,334, 350, 358, 364, 369 to wxEVT_GRID_CELL_CHANGED
findit.cpp Line 223 249 276 from 'SetRowHeight' to ? (maybe keep it?)

https://docs.wxwidgets.org/trunk/classwx_grid_event.html
https://docs.wxwidgets.org/trunk/search.php?query=SetRowHeight

[ptulp]

Change line 221, 226, 247, 252, 271 from GetRowHeight to GetRowSize
Change line 223, 249, 276 from SetRowHeight to SetRowSize

Peter

[rgleason]

Getting there

https://ci.appveyor.com/project/rgleason/findit-pi/builds/22907143

uild FAILED.
"C:\project\findit_pi\build\package.vcxproj" (default target) (1) ->
"C:\project\findit_pi\build\ALL_BUILD.vcxproj" (default target) (3) ->
"C:\project\findit_pi\build\findit_pi.vcxproj" (default target) (4) ->
(ClCompile target) -> 
  C:\project\findit_pi\src\gui.cpp(315): error C2065: 'wxEVT_GRID_CELL_CHANGE' : undeclared identifier [C:\project\findit_pi\build\findit_pi.vcxproj]
  C:\project\findit_pi\src\gui.cpp(323): error C2065: 'wxEVT_GRID_CELL_CHANGE' : undeclared identifier [C:\project\findit_pi\build\findit_pi.vcxproj]
  C:\project\findit_pi\src\gui.cpp(329): error C2065: 'wxEVT_GRID_CELL_CHANGE' : undeclared identifier [C:\project\findit_pi\build\findit_pi.vcxproj]
  C:\project\findit_pi\src\gui.cpp(334): error C2065: 'wxEVT_GRID_CELL_CHANGE' : undeclared identifier [C:\project\findit_pi\build\findit_pi.vcxproj]
  C:\project\findit_pi\src\gui.cpp(350): error C2065: 'wxEVT_GRID_CELL_CHANGE' : undeclared identifier [C:\project\findit_pi\build\findit_pi.vcxproj]
  C:\project\findit_pi\src\gui.cpp(358): error C2065: 'wxEVT_GRID_CELL_CHANGE' : undeclared identifier [C:\project\findit_pi\build\findit_pi.vcxproj]
  C:\project\findit_pi\src\gui.cpp(364): error C2065: 'wxEVT_GRID_CELL_CHANGE' : undeclared identifier [C:\project\findit_pi\build\findit_pi.vcxproj]
  C:\project\findit_pi\src\gui.cpp(369): error C2065: 'wxEVT_GRID_CELL_CHANGE' : undeclared identifier [C:\project\findit_pi\build\findit_pi.vcxproj]
    0 Warning(s)
    8 Error(s)

Change these to wxEVT_GRID_CELL_CHANGED?

[ptulp]

Yes, that should do it.

[ptulp]

I will be out for a few hours for dinner.

Regards,
Peter

[rgleason]

Ta da! That one worked.
https://ci.appveyor.com/project/rgleason/findit-pi

Here's the file I'm after for Windows!
https://ci.appveyor.com/project/rgleason/findit-pi/build/artifacts
Just have to add ov50 into it and test it out. (making this automatic is the next step...but later)
Pavel and sean have some examples.

[rgleason]

Ps If you want to make a new branch called ov50, I can then create a PR pointed to your "ov50" branch .
Ps I also have an ov42 directory which has the build for Opencpn 4.2 - 4.8.8 in it. If you make that branch too, I will make a PR for that branch too.