Comments (4)
I think the comment above is partly wrong.
The eaton ups exporter already uses requests
to disable the SSL verification with:
self.session.verify = not insecure # ignore self signed certificate
, but this is not what it uses urllib3
for.
When using requests session.verify = False
this means SSL verification is ignored, which the people of requests discussed, and they decided that that makes a warning about this behavior necessary.
It is possible to use urllib3.disable_warnings()
to disable these warnings -> and this is what is what the eaton ups exporter is doing and what urllib3
is used for.
from prometheus-eaton-ups-exporter.
Discussion about this in requests
: psf/requests#2214
To remove the dependency we could just allow the warning to happen.
from prometheus-eaton-ups-exporter.
Ahh, thanks for sharing that. Indeed that's different than I thought.
I would prefer a solution more in the line of one of these two:
They both solve this problem different ways, but in common, they import from the requests
namespace, which makes the intent and relation more obvious.
from prometheus-eaton-ups-exporter.
urllib3
is a dependency for requests
, so it's going to be part of the package environment anyway, but I vastly prefer the solution @aqw suggested. Note that this is a remnant directly copied from the Raritan PDU Exporter back when it used requests
and multi-threading instead of aiohttp
and asynchronous operations.
Perhaps it is worth considering doing the same for this exporter, if the time investment is deemed worthwhile.
from prometheus-eaton-ups-exporter.
Related Issues (18)
- Missing files HOT 1
- Create setup.py with entry points HOT 1
- Multi threading
- combine --port and --host-address HOT 2
- select a default/suggested port HOT 1
- rename repo to prometheus-eaton-ups-exporter HOT 5
- HELP strings should be more... helpful
- User-Agent should not be spoofed HOT 4
- percent should be "ratio" HOT 10
- regression: --web.listen-address no longer allows listening on all interfaces HOT 2
- exporter returns error when a UPS is unreachable HOT 2
- document values of battery health (if possible) HOT 3
- "health status" value reported by UPS is unclear (help wanted) HOT 1
- Integrate tests
- Problem HOT 4
- Exporter not working on UPS Firmware 2.0.5 HOT 4
- add automated credential removal for casettes to tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prometheus-eaton-ups-exporter.