Coder Social home page Coder Social logo

Comments (4)

TobiasKadelka avatar TobiasKadelka commented on August 26, 2024

I think the comment above is partly wrong.

The eaton ups exporter already uses requests to disable the SSL verification with:
self.session.verify = not insecure # ignore self signed certificate, but this is not what it uses urllib3 for.

When using requests session.verify = False this means SSL verification is ignored, which the people of requests discussed, and they decided that that makes a warning about this behavior necessary.

It is possible to use urllib3.disable_warnings() to disable these warnings -> and this is what is what the eaton ups exporter is doing and what urllib3 is used for.

from prometheus-eaton-ups-exporter.

TobiasKadelka avatar TobiasKadelka commented on August 26, 2024

Discussion about this in requests: psf/requests#2214

To remove the dependency we could just allow the warning to happen.

from prometheus-eaton-ups-exporter.

aqw avatar aqw commented on August 26, 2024

Ahh, thanks for sharing that. Indeed that's different than I thought.

I would prefer a solution more in the line of one of these two:

They both solve this problem different ways, but in common, they import from the requests namespace, which makes the intent and relation more obvious.

from prometheus-eaton-ups-exporter.

nhjjr avatar nhjjr commented on August 26, 2024

urllib3 is a dependency for requests, so it's going to be part of the package environment anyway, but I vastly prefer the solution @aqw suggested. Note that this is a remnant directly copied from the Raritan PDU Exporter back when it used requests and multi-threading instead of aiohttp and asynchronous operations.

Perhaps it is worth considering doing the same for this exporter, if the time investment is deemed worthwhile.

from prometheus-eaton-ups-exporter.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.