not compatible with Node 12? about flightplan

[cullylarson]

I'm having the same problem. Using node 12 on macos, failing to build [email protected]. Getting errors like this:

> [email protected] install /Users/me/npm/lib/node_modules/flightplan/node_modules/fibers
> node build.js || nodejs build.js

  CXX(target) Release/obj.target/fibers/src/fibers.o
../src/fibers.cc:68:2: error: no template named 'Handle'
        Handle<String> NewLatin1String(Isolate* isolate, const char* string) {
        ^
../src/fibers.cc:69:10: error: no viable conversion from returned value of type 'Local<v8::String>'
      to function return type 'int'
  ...String::NewFromOneByte(isolate, (const uint8_t*)string, NewStringType::kNormal).ToLocalChecked();

../src/fibers.cc:72:2: error: no template named 'Handle'
        Handle<String> NewLatin1Symbol(Isolate* isolate, const char* string) {
...

Fibers@4 builds fine, but like @rsinger86 said, flightplan depends on fibers@3.

[pstadler]

Glad you like this project. Please provide a PR.

[Zwimber]

Checked and the commit seems to work!

[pstadler]

This has been fixed with 0.6.20. Thanks!