Comments (4)
Thanks for reporting this issue.
Unfortunately I'm unsure how to reproduce this, looking at our PSPDFKit Instant codebase we have test cases with exactly the same pattern that all do work.
Can you post a complete failing example, so I can reproduce and debug?
from bypass.
Sorry for the slow reply @MSch, turns out that I slightly mis-represented the failing test case in my issue description, that's why you haven't been able to reproduce it.
The codebase I refer to is actually using setup_all
callbacks as opposed to setup
ones.
Here is a before/after PR: swoosh/swoosh#149
I'm wondering if that should still be mentioned as a breaking change somewhere, or if setup_all
were never expected to work nicely with Bypass.
from bypass.
No worries @stevedomin and I'm glad we figured it out and it's working for you now 👍
You're right, setup_all
was never meant to be the right place for Bypass.open
to be called, because Bypass needs to be able to verify the expectation, and that happens at the end of the test.
So in that case it's not a breaking change, since it never was expected to work.
I'm closing this, but please let me know if you think there's a way to improve the documentation to make these expectations clearer. A PR is welcome too :)
from bypass.
Thanks @MSch, opened a PR with a note in the README: #46
from bypass.
Related Issues (20)
- Pipe expectations
- Add 'headers' param in expect and expect_once function HOT 1
- Building error with erlang 22 HOT 3
- Update cowlib dependency HOT 3
- Cannot wait (with timeout) for expectations HOT 4
- How to use bypass with Finch? HOT 2
- How to test request timeout with bypass? HOT 2
- Any support for ranch 2.x? HOT 1
- Crash on shutdown in `dispatch_awaiting_callers` HOT 2
- bypass randomly fails with eaddrinuse error
- bypass does not support paths containing ":" HOT 2
- Error initializing bypass HOT 1
- Match on request body HOT 1
- dialyzer issue
- Elixir 1.15 incompatible? HOT 1
- Warning on Elixir 1.16 HOT 3
- Support for bandit instead plug_cowboy
- Multiple expect_once HOT 4
- New release? HOT 5
- Move primary documentation out of the README HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bypass.