corelightning + suez about suez

[lirre8]

I guess it shouldn't be too much problem to add some checks on what fields are available, to support both old and new versions of cln. I can work on a fix for that

[TTK-199837]

Working! Thanks a lot!

[prusnak]

What version of CLN are you running? Is it the latest?

[TTK-199837]

Yes, the latest!

…

On Wed, Mar 22, 2023, at 10:20 AM, Pavol Rusnak wrote: What version of CLN are you running? Is it the latest? — Reply to this email directly, view it on GitHub <#46 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AND3BCWNG4WB752DQAQFW2LW5MYFNANCNFSM6AAAAAAWD6Q3RQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[prusnak]

Can you try using "git bisect" to find which commit broke this?

https://git-scm.com/docs/git-bisect

[TTK-199837]

Hi! I believe the version I was running was before this update:

45e16bf

[TTK-199837]

I am running suez on nix-bitcoin / nixOS btw

[prusnak]

Can you try "git bisect" like instructed above?

[prusnak]

@lirre8 which version of CLN did you use to test your commit?

[TTK-199837]

I am going through the bisect process again. I think I might have messed up something, please bear with me.

Removed old messages as to not confuse everyone. Thanks!

[TTK-199837]

[operator@nixos:~/suez]$ git bisect good
bd90bb3 is the first bad commit
commit bd90bb3
Author: Sebastian Andersson [email protected]
Date: Sat Mar 4 11:33:34 2023 +0100

Add option to show min and max htlc

clnclient.py | 18 ++++++++++++++++++
lndclient.py | 26 ++++++++++++++++++++++----
suez.py | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++--
3 files changed, 95 insertions(+), 6 deletions(-)

[lirre8]

@lirre8 which version of CLN did you use to test your commit?

I've been using v22.11.1, which is not the latest anymore but pretty much up to date. But as I mentioned in #42 (comment), it seems like the cln implementation is using fields that have been removed a while ago, so the latest version of cln doesn't work at all..

I should probably have checked that the htlc_minimum_msat was returning the expected value even for older version, sorry for that. So it seems now that neither an old or newer version will work..

I guess we could fix so that htlc_minimum_msat and htlc_maximum_msat works with the older version of cln that was working before that commit. But shouldn't we update it so it works with the latest version?

Note: So what I'm saying here is the you are probably not using the latest version of cln @TTK-199837, can you check the exact version by running lightning-cli --version?

[prusnak]

My goal is to support only the most recent version of CLN. If it's easy to support previous versions, let's do it, but if it's a problem, then let's skip it.

[TTK-199837]

Hi! running lightning-cli --version outputs: v23.02.2

[lirre8]

OK, so you are on the latest version, I guess I was wrong. But weird that my CLN node has different outputs than yours then, I have to look into that

[TTK-199837]

Please let me know if there is anything I can help with! Thanks a lot!

I would like to mention again that fee adjustments seem broken... I am using:

poetry run ./suez --client=c-lightning --base-fee 0 --fee-rate 500 --fee-spread 1.8

[lirre8]

I can't make any sense on why our CLN nodes would return different data. As far as I can tell, my node does it according to the latest docs: https://lightning.readthedocs.io/lightning-listpeers.7.html. If anyone could explain why your node differs in some field names and values I'd be very happy :)

Anyway, it's an easy problem to solve to just add some checks on the fields that differs and handle them accordingly. I have created a PR that works fine for me: #47

Regarding the issue with fee adjustment, I'm seeing this error after adding some debug logs: Command "setchannelfee" is deprecated. But this is a completely different problem, lets open a separate issue for that: #48

[lirre8]

@TTK-199837 The PR was merged, can you pull the latest code from master and check if it's working when you have a chance?