All commands must honour `denote-prompts`, mutatis mutandis about denote

[protesilaos]

Thank you @vedang! I will merge your PR, subject to a stylistic change noted there.

Finally, denote-org-capture uses denote-prompts, but I didn't look at this bit of the code deeply.

I have not tested it lately, but I believe everything is okay with it.

If we have any other cases, let's discuss them here and proceed accordingly.

I will continue work on the rename-honours-denote-prompts branch as soon as possible. Then merge everything into main.

[vedang]

This is so cool @protesilaos ! I looked at the code and tested the following scenarios successfully:

• Rename a note with M-x denote-rename-file
• Rename a note with point on filename Dired buffer
• Rename a note with using front-matter (check that denote-prompts is not invoked)

Post that, I checked to see which code-paths could be changed to respect denote-prompts.

The following paths already call denote or other commands interactively and therefore respect denote-prompts correctly:

• denote-region
• denote-open-or-create
• denote-link-or-create
• denote-link-after-creating

The following commands use a fixed list, and therefore overwrite denote-prompts:

• denote-type
• denote-date
• denote-subdirectory
• denote-template
• denote-signature

All of these can be modified to use denote-prompts, which is a change I am submitting on top of the current commit (see #248).

Finally, denote-org-capture uses denote-prompts, but I didn't look at this bit of the code deeply.

[protesilaos]

I just merged everything into main. I made lots of changes/refinements to ancillary functions as well.

[protesilaos]

Sorry, I mean I merged the branch rename-honours-denote-prompts. I will take care to delete it before the new release.

[protesilaos]

I think we are done with this for now. If there is any command we missed, we can always update it later. Thanks!