Coder Social home page Coder Social logo

README feedback about denote HOT 4 CLOSED

protesilaos avatar protesilaos commented on July 28, 2024
README feedback

from denote.

Comments (4)

protesilaos avatar protesilaos commented on July 28, 2024 1

Some user might do that and then wonder whey denote-link doesn't
work.

True. Will remove this part.

Additionally, if there is no identifier match, denote-link throws an
error with backtrace i.e. it's not an elegant user-error.

Better fix this then to fail gracefully. I will most likely not be able
to do this right now, as I am about to go bed. Tomorrow for sure!

from denote.

protesilaos avatar protesilaos commented on July 28, 2024

Better fix this then to fail gracefully. I will most likely not be able to do this right now, as I am about to go bed. Tomorrow for sure!

I believe I fixed this while also moving the relevant code to its own file instead of keeping it in denote-link.el. The relevant part:

(defun denote-retrieve--search (regexp)
  "Search for REGEXP in the current buffer."
  (save-excursion
    (save-restriction
      (widen)
      (goto-char (point-min))
      (re-search-forward regexp nil t 1)
      (match-string-no-properties 1))))

(defun denote-retrieve--find-value (regexp)
  "Return value from REGEXP by searching the file."
  (or (denote-retrieve--search regexp)
      (user-error "Cannot retrieve %s" regexp)))

from denote.

kaushalmodi avatar kaushalmodi commented on July 28, 2024

Thanks! I'll close this issue then.

from denote.

protesilaos avatar protesilaos commented on July 28, 2024

Thank you!

from denote.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.