Coder Social home page Coder Social logo

Comments (7)

imlk0 avatar imlk0 commented on September 4, 2024 2

@KB5201314 has this been resolved with #14?

No, there still seems to be a problem with this part, because the args are not handled properly.

let mut argv = PathBuf::from(path.as_bstr().to_path().unwrap());
argv.push(arg.as_bstr().to_path().unwrap()); // FIXME: why append arg here?
Ok(Some(argv))

The current code will process #!/bin/sh -x into /bin/sh/-x

Maybe we have to replace the return value of this function from Result<Option<PathBuf>> with something else. Maybe Result<Option<(PathBuf, Bstring)>>?

from proot-rs.

panicbit avatar panicbit commented on September 4, 2024

I'd like to look into this.

from proot-rs.

panicbit avatar panicbit commented on September 4, 2024

If this project isn't completely abandoned...

from proot-rs.

jyn514 avatar jyn514 commented on September 4, 2024

@panicbit right - I have an open PR at #9 but it hasn't been reviewed in a year.

from proot-rs.

oxr463 avatar oxr463 commented on September 4, 2024

@panicbit @jyn514 I would gladly assign either of you maintainer access for this rust implementation. I am currently the only "active" maintainer and to be honest, I barely have bandwidth for the main implementation.

from proot-rs.

oxr463 avatar oxr463 commented on September 4, 2024

@KB5201314 has this been resolved with #14?

from proot-rs.

imlk0 avatar imlk0 commented on September 4, 2024

Fixed in #47

from proot-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.