Coder Social home page Coder Social logo

Comments (2)

bergus avatar bergus commented on June 19, 2024

The Promises/A+ then method does not support fulfilling with thenables (when returning them from the then callback`). This spec does not say anything about the constructor, it doesn't answer your question.

You can do either. You should decide whether the callback in your constructor is a resolve or a fulfill. You got three choices:

  • It fulfills the promise with the passed value. In that case final should be logging the promise2.
  • It resolves the promise, using thenable assimilation. In that case final should be logging 5.
  • It resolves the promise by adopting the passed promise. In that case final should reject, because promise1 and promise2 are rejected promises, because 5 was not a valid promise.

from promises-spec.

paulstelian97 avatar paulstelian97 commented on June 19, 2024

I'm pretty sure promise1 should resolve to the value 5, but otherwise thank you. I have chosen to call then() in the constructor (without that final would resolve to promise2 in my implementation)

Note that it passes all tests in the tests repo either way (it's inspired by RWPromises)

from promises-spec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.