filter cache was already renamed in Elasticsearch 2.0 about elasticsearch_exporter

[zwopir]

Hi Manabu,

sorry for the late reply. We currently support ES down to version 1.7.6. So removing
elasticsearch_indices_filter_cache_evictions and elasticsearch_indices_filter_cache_memory_size_bytes would break 1.7.6.

Please refer to the json included inline in the files ./collector/cluster_health_test.goand ./collector/nodes_test.go for further details.

We happily accept PRs for missing metrics. For the proposed metrics I suggest some changes:

• elasticsearch_indices_query_cache_hit_rate (hit_count / total_count * 100)

please don't include it, it can be calculated via promQL. Also the word 'rate' is misleading as it is usually used in the sense of 'change per time'

For the cache metrics elasticsearch_indices_query_cache_total_count, elasticsearch_indices_query_cache_hit_count and elasticsearch_indices_query_cache_miss_count (and the similar ones)

I suggest the following metrics instead

• elasticsearch_indices_query_cache_total: type counter
• elasticsearch_indices_query_cache_count: type countervec with a label cache beeing hit or miss.

Feel free to find a better label name, as 'cache' is quite generic

[matsumana]

Hello, Would you tell me what you think?

[matsumana]

Thank you for the comment.

We currently support ES down to version 1.7.6.

I got it.

We happily accept PRs for missing metrics. For the proposed metrics I suggest some changes:

I agree with you. I would like to implement like that and send PR.

[zwopir]

#88 resolves one part of the issue, the renaming stays untouched as we support both versions