Path Normalization about prom-client-httprequestdurations

[zihotki]

Another option could be to use Route (api/cities/{id}) instead of a Path (api/cities/2342) and avoid using RegExes if possible. This way it'll be also easier to detect wildcard routes "/api/search/{*searchString}". What do you think?

[phnx47]

I will write prototype for test. And then I'll think about how best to work with it.

[dmeenhuis]

Any progress with this? I'm trying to get metrics for request durations that also include paths, but it would be a lot more useful if there is a way to normalize ID values.

[phnx47]

@dmeenhuis I will come back to this issue soon.

Thank you!

[dmeenhuis]

Thanks! I managed to fork this repo and incorporate the changes in the linked PR and for now that seems to work fine, although it contains a minor bug for the integer normalization (it doesn't properly deal with integer values at the end of the path, where there is no trailing slash).

Would love to see an update from your end, thanks for this very useful library so far 👍

[zihotki]

Thanks! I managed to fork this repo and incorporate the changes in the linked PR and for now...

@dmeenhuis Is it me or you didn't push or create a PR? I can't find it in this repo

[dmeenhuis]

It's not you, I didn't actually push the changes yet. Can do that tomorrow if you like.

[phnx47]

I finished work with this:prom-client-net/prom-client#18

Now, I can come back to this issue

[phnx47]

Released. 1.1.0

[phnx47]

Regex examples

[phnx47]

If something does not work, then reopen.